add a new "YY" (uppercase yy) parsing option to strictly parse two digit year #1162
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…git year the current lowercase "yy" also accepts 4-digits, which fails if the date has no separators and other not-strict length tokens in it. eg. the date "22031609025910" fails to parse with "yyMMddHHmmssuu" -> reason: "unit out of range", explanation: "you specified 31 (of type number) as a month, which is invalid"
|
|
|
good question. I don't like YY, but I also don't have a better idea. yyy is free, but that's also confusing. Let me think on this; I agree that Luxon should support this |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the current lowercase "yy" also accepts 4-digits, which fails if the date has no separators and other not-strict length tokens in it.
eg. the date "22031609025910" fails to parse with "yyMMddHHmmssuu" -> reason: "unit out of range", explanation: "you specified 31 (of type number) as a month, which is invalid"
This commit adds a new token "YY" (in addition to the lowercase "yy") which strictly limits the parser to 2 digit years. Also adds a test.
Request for Feedback: also add uppercase variants for the other token settings, so that it is more coherent?