Create @modrinth/i18n package #2161
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This changes Turborepo config in the workspace root to be explicit. Explicity in this case means that all tasks are defined manually and all inputs are also specified manually. While that might seem redundant, this allows to orchestrate and adjust tasks more carefully - ignoring some files while taking other files into account, only hashing and providing project-specific variables, explicitly reviewing and specifying dependencies. That might come in handy in the future. There's an alternative way to approach this, which is to have every package contain "turbo.json" file, however, for now the flat approach has been chosen as it seems to be the most cleanest and easiest to review.
brawaru
force-pushed
the
feat/i18n/move-to-pkg
branch
from
3a56cbb
to
f6e9776
Compare
@modrinth/i18n will be a package that contains the common messages that are used by two or more packages, as well as utilities for working with localisation, such as `defineMessage` macro and locale files resolver abstraction. It is pre-built in a manner that allows for harsh tree-shaking, meaning the messages that will not be used, should not be included by the bundlers. All messages are also defined using the `defineMessage` macro that cleans the descriptors and pre-parses `defaultMessage` to AST, which serves both as validation, as well as allows its use as fallback even in environments devoid of bundled-in compiler. When all other code parts are switched to use this macro, this might allow to exclude messages files for English language, potentially saving on removed duplication. Please note that currently `defineMessages` does not include `defaultMessage` because it is expected that consumers of `@modrinth/i18n` will include and pre-compile extracted messages file. This can be overriden by setting `MODRINTH_I18N_DEFAULT_MESSAGE` environment variable to `1`.
brawaru
force-pushed
the
feat/i18n/move-to-pkg
branch
from
f6e9776
to
f494ab7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on #2150.
TBD