fix(theseus): only auto select gameVersion and loader when possible #1262
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Is this pr will fix also the problem with shaders and vanilla-only datapacks? |
|
yes, when every some filter caused no versions to be displayed this filter will no longer be applied |
# Conflicts: # apps/app-frontend/src/pages/project/Versions.vue
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
currently, when adding content to an instance and adding a resource pack, the Versions tab auto inserts e.g Fabric as a loader even though there isn't a fabric specific version
This PR changes it so it only auto inserts the GameVersion and Loader if there is a version made for them.
resolves #1276
reopen of #1203