Theseus: Fix scrolling to top problems #1249
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Norbiros
force-pushed
the
fix/theseus/scroll
branch
from
4c06fc1
to
3364906
Compare
Geometrically
approved these changes
Jul 7, 2024
ToBinio
pushed a commit
to ToBinio/olympus
that referenced
this pull request
Jul 8, 2024
* Initial commit * Update launcher.vue * Finalize landing page!!!!!!! * Run linter * Address some changes * Address changes * Lint * addressed more changes * Add os logos * Use install urls for linux * Update app.vue * intuitive buttons
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: PR #1232 has been reopened following the switch to a monorepo organization.
This PR fixes an issue where Vue's scrolling behaviour inconsistently failed to scroll to the top of the entire page on certain desktop environments or operating systems. The problem occurred because Theseus has scrolling within an inner container rather than the entire page, leading to inconsistent behaviour.