first step to get electron browser running, but tests not working yet #2818
Conversation
|
| @@ -24,7 +24,7 @@ git remote add upstream [email protected]:modernweb-dev/web.git | |||
| Now that you have cloned the repository, ensure you have node 18+ installed, then run the following command to set up the development environment. | |||
|
|
|||
| ```sh | |||
| npm install | |||
| npm clean-install | |||
There was a problem hiding this comment.
I committed package-lock.json, and running npm clean-install will ensure that the setup is reproducible for the next person (npm install will update dependencies which always has a risk of breaking something).
| if (this.browser) { | ||
| if (!('isConnected' in this.browser) || this.browser.isConnected()) { | ||
| await this.browser.close(); | ||
| } |
There was a problem hiding this comment.
The ElectronApplication instance does not have a isConnected method.
| createPage = ({ context }) => context.newPage(), | ||
| createBrowserContext = ({ browser }) => { | ||
| if ('browserWindow' in browser) { | ||
| return browser.context(); |
There was a problem hiding this comment.
There is no newContext() method on the ElectronApplication instance. There seems to be a single context for the whole ElectronApplication only, so maybe this is why the tests are not working?
| }, | ||
| createPage = ({ context, browser }) => { | ||
| if ('browserWindow' in browser) { | ||
| return browser.firstWindow(); |
There was a problem hiding this comment.
The firstWindows is a playwright Page. Maybe for Electron we need to open and close windows, instead of making contexts?
| // testFailure: true, | ||
| // locationChanged: true, | ||
| // }); | ||
| // }); |
There was a problem hiding this comment.
- TODO re-enable other tests before mering
TODO:
playwrite._electronexperimental Electron launcher.