Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump chokidar v4 #2813

Merged
merged 3 commits into from
Sep 26, 2024
Merged

Conversation

talentlessguy
Copy link
Contributor

What I did

  1. Bumped chokidar to v4.0.1 which removes 11 dependencies and has better TypeScript support

local test pass, and it builds locally as well

Copy link

changeset-bot bot commented Sep 23, 2024

🦋 Changeset detected

Latest commit: 8b98279

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@web/test-runner-core Patch
@web/dev-server-core Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@bashmish
Copy link
Member

removes 11 dependencies

from the lock file it seems that older chokidar is still used by some packages, which might mean we get more deps as a result on an average project that depends on multiple @web/ packages
can you please double check that?
it's a pity if we solve this only partially and make deps more of an issue then

@talentlessguy
Copy link
Contributor Author

talentlessguy commented Sep 26, 2024

@bashmish an old version of unplugin is used that depends on v3.6 chokidar. the latest. v1.12.3 of unplugin doesn't depend on chokidar anymore.

and that dependency is a dev dep, it doesn't get into into install size

@bashmish bashmish merged commit 2204e25 into modernweb-dev:master Sep 26, 2024
8 checks passed
@talentlessguy talentlessguy deleted the bump-chokidar-v4 branch September 26, 2024 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants