Clang formatting traces #1319
Closed
Clang formatting traces #1319
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It looks like this PR fails our clang-format CI check. Which version of clang-format are you using? |
|
Yep, on those exact 3 lines. I'm running |
|
14 was the version that we did the initial clang-format with. We can upgrade, but haven't gotten around to it yet. |
|
I can try to help with that if you want me to. I'm in the middle of it from our side, and looks like it will only pull 3 simple changes in the repository. |
|
Feel free to send us a PR bumping the clang-format version and doing the clang-format to all affected files! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When applying the new formatting from our side, I noticed these three files (one line each), had been left over.