Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow branches without label #407

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

pelletier
Copy link

The control flow graph pass does not allow jumps that don't point to a label. In my case, I'd like to jump out of the current function to a different fallback function. I didn't see any reason why this would not be permitted in the current codebase, except if the goal is to force a control flow graph contained within the function explicitly.

This branch is based on #406, but I'm happy to break it out if it's easier to review.

@pelletier
Copy link
Author

@mmcloughlin As I'm going to be reworking #406, do you have any opinion on this change? e86a5cc

Copy link

@Jorropo Jorropo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just looked at e86a5cc, I need this feature too and the implementation looks good.
A test testing JMP to an other function generates correctly might be nice.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants