gotypes: Handle named types in Component.Resolve

mmcloughlin · Mar 17, 2023 · e9306ff · e9306ff
1 parent fc7bbb8
commit e9306ff
Show file tree

Hide file tree

Showing 4 changed files with 6 additions and 4 deletions.
diff --git a/examples/args/README.md b/examples/args/README.md
@@ -71,7 +71,7 @@ type Struct struct {
 	Int8       int8
 	Uint16     uint16
 	Int32      int32
-	Uint64     uint64
+	Uint64     NamedUint64
 	Float32    float32
 	Float64    float64
 	String     string

diff --git a/examples/args/args.go b/examples/args/args.go
@@ -6,7 +6,7 @@ type Struct struct {
 	Int8       int8
 	Uint16     uint16
 	Int32      int32
-	Uint64     uint64
+	Uint64     NamedUint64
 	Float32    float32
 	Float64    float64
 	String     string
@@ -16,6 +16,8 @@ type Struct struct {
 	Complex128 complex128
 }
 
+type NamedUint64 uint64
+
 // Sub is a sub-struct of Struct, to demonstrate nested datastructure accesses.
 type Sub struct {
 	A uint64

diff --git a/examples/args/args_test.go b/examples/args/args_test.go
@@ -21,7 +21,7 @@ func TestFunctionsEqual(t *testing.T) {
 		{FieldInt8, func(s Struct) int8 { return s.Int8 }},
 		{FieldUint16, func(s Struct) uint16 { return s.Uint16 }},
 		{FieldInt32, func(s Struct) int32 { return s.Int32 }},
-		{FieldUint64, func(s Struct) uint64 { return s.Uint64 }},
+		{FieldUint64, func(s Struct) uint64 { return uint64(s.Uint64) }},
 		{FieldFloat32, func(s Struct) float32 { return s.Float32 }},
 		{FieldFloat64, func(s Struct) float64 { return s.Float64 }},
 		{FieldStringLen, func(s Struct) int { return len(s.String) }},

diff --git a/gotypes/components.go b/gotypes/components.go
@@ -74,7 +74,7 @@ func NewComponent(t types.Type, addr operand.Mem) Component {
 }
 
 func (c *component) Resolve() (*Basic, error) {
-	b := toprimitive(c.typ)
+	b := toprimitive(c.typ.Underlying())
 	if b == nil {
 		return nil, errors.New("component is not primitive")
 	}