created directory_dialog for windows and linux #48
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@mattVHartley I extended your implementation to apple. I am wondering what is the use-case of |
wjakob
force-pushed
the
master
branch
3 times, most recently
from
34e97f1
to
b94e8a7
Compare
wjakob
force-pushed
the
master
branch
4 times, most recently
from
f88c1ac
to
69464ef
Compare
|
Sorry for taking a very, very (!) long time to respond. This looks useful, but to actually consider merging it, there would need to be a macOS code-path as well. |
wjakob
force-pushed
the
master
branch
11 times, most recently
from
e9c6fc9
to
0f47fe0
Compare
arpit15
added a commit
to Robo-Touch/nanogui
that referenced
this pull request
Sep 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've implemented a directory dialog that works on windows and on linux,
I've used zenity for linux (implementation is practically the same as file_dialog, albeit with an extra arg)
Windows uses SHBrowseForFolder and required the including shlobj.h