Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added resizable window class #40

Closed
wants to merge 1 commit into from

Conversation

christophe-f8
Copy link

I've added a ResizableWindow class that is based on the standard Window class.

The window can be resized horizontally and vertically, but only a vertical scrollbar is implemented so there is a different behavior for width and height:

  • Width can not be resized smaller than the minimum width needed to fully display all widgets
  • If the width is more than the minimum needed, the layout of the window stretch horizontally
  • Height can be resized smaller than the minimum height needed to fully display all widgets if enforceMinimumHeight is set to true in the constructor. In such case a scrollbar appears.
  • If the height is more than the minimum needed, a blank area appears at the bottom of the window.

The main thinking behind this behavior is that horizontal scrollbars are probably bad UI design anyway. This might not suit the needs of everyone, but I'm creating this PR should people need this (or want to extend it further)

Hope it helps !

@NeuralDip
Copy link

Hello, to me this is a very useful feature.
I have merged it locally to the master branch and it does not have any serious conflicts.
Is this going to be merged? Is there any reason why you don't plan to merge it?
Best Regards

@wjakob wjakob force-pushed the master branch 3 times, most recently from 34e97f1 to b94e8a7 Compare September 6, 2020 19:45
@christophe-f8
Copy link
Author

Closing this PR because it now has conflicts and @NeuralDip created a new/better PR #55 .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants