Adjust testPresignedPostPolicy to ensure that GetObject... #1996
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8 tasks
marktheunissen
changed the title
marktheunissen
force-pushed
the
checksumpostpolicy
branch
from
df3d6c9
to
5de5dbe
Compare
marktheunissen
commented
Sep 2, 2024
| logError(testName, function, args, startTime, "", "PutObject failed", err) | ||
| return | ||
| } | ||
|
|
There was a problem hiding this comment.
I think this was just a copy paste mistake, not sure why we were doing a PutObject here, as we are running the PostPolicy presigned request via the http client further down.
marktheunissen
commented
Sep 2, 2024
klauspost
reviewed
Sep 5, 2024
Comment on lines
+310
to
+330
| // Needed for S3 compatibility. MinIO ignores the checksum keys in the policy. | ||
| // https://github.com/minio/minio/blob/RELEASE.2024-08-29T01-40-52Z/cmd/postpolicyform.go#L60-L65 |
There was a problem hiding this comment.
@jiuker You added this in minio/minio#18074
I don't understand why these should be ignored, which seems like a bug.
There was a problem hiding this comment.
I spoke to Jiuker and he agrees it is a bug, so I will remove the ignores in a PR to minio/minio
…orrect checksum. Add checksum headers to policy
marktheunissen
force-pushed
the
checksumpostpolicy
branch
from
5de5dbe
to
cf2b561
Compare
|
FYI to myself: minio/minio#18074 (comment) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
...returns the correct checksum. Add checksum headers to policy
For the following issue: minio/minio#20343