Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support tags for postPolicy Upload #1967

Merged
merged 3 commits into from
May 29, 2024

Conversation

jiuker
Copy link
Contributor

@jiuker jiuker commented May 28, 2024

feat: support tags for postPolicy Upload
related: minio/minio#19816

Copy link
Contributor

@shtripat shtripat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Member

@vadmeste vadmeste left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not too much into adding a new API since we can have multiple operators here, other than eq

The user can use SetCondition() I believe (after fixing it)

post-policy.go Show resolved Hide resolved
@jiuker
Copy link
Contributor Author

jiuker commented May 28, 2024

I am not too much into adding a new API since we can have multiple operators here, other than eq

The user can use SetCondition() I believe (after fixing it)

SetCondition will not support tagging. And according to the minio pr @ramondeklein mention the document introduced tagging is a single special field https://docs.aws.amazon.com/AmazonS3/latest/API/RESTObjectPOST.html. So I want to add that into a function @vadmeste

@jiuker jiuker requested a review from vadmeste May 29, 2024 09:03
@harshavardhana harshavardhana merged commit 7d712b5 into minio:master May 29, 2024
5 checks passed
charithe referenced this pull request in cerbos/cerbos Jun 10, 2024
[![Mend
Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence | Type |
Update |
|---|---|---|---|---|---|---|---|
| [github.com/aws/aws-sdk-go](https://togithub.com/aws/aws-sdk-go) |
`v1.53.14` -> `v1.53.19` |
[![age](https://developer.mend.io/api/mc/badges/age/go/github.com%2faws%2faws-sdk-go/v1.53.19?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![adoption](https://developer.mend.io/api/mc/badges/adoption/go/github.com%2faws%2faws-sdk-go/v1.53.19?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![passing](https://developer.mend.io/api/mc/badges/compatibility/go/github.com%2faws%2faws-sdk-go/v1.53.14/v1.53.19?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![confidence](https://developer.mend.io/api/mc/badges/confidence/go/github.com%2faws%2faws-sdk-go/v1.53.14/v1.53.19?slim=true)](https://docs.renovatebot.com/merge-confidence/)
| require | patch |
|
[github.com/cerbos/cerbos/api/genpb](https://togithub.com/cerbos/cerbos)
| `f2ad52f` -> `a1a7010` | | | | | require | digest |
| [github.com/minio/minio-go/v7](https://togithub.com/minio/minio-go) |
`v7.0.70` -> `v7.0.71` |
[![age](https://developer.mend.io/api/mc/badges/age/go/github.com%2fminio%2fminio-go%2fv7/v7.0.71?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![adoption](https://developer.mend.io/api/mc/badges/adoption/go/github.com%2fminio%2fminio-go%2fv7/v7.0.71?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![passing](https://developer.mend.io/api/mc/badges/compatibility/go/github.com%2fminio%2fminio-go%2fv7/v7.0.70/v7.0.71?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![confidence](https://developer.mend.io/api/mc/badges/confidence/go/github.com%2fminio%2fminio-go%2fv7/v7.0.70/v7.0.71?slim=true)](https://docs.renovatebot.com/merge-confidence/)
| require | patch |
| [go](https://go.dev/) ([source](https://togithub.com/golang/go)) |
`1.22.3` -> `1.22.4` |
[![age](https://developer.mend.io/api/mc/badges/age/golang-version/go/1.22.4?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![adoption](https://developer.mend.io/api/mc/badges/adoption/golang-version/go/1.22.4?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![passing](https://developer.mend.io/api/mc/badges/compatibility/golang-version/go/1.22.3/1.22.4?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![confidence](https://developer.mend.io/api/mc/badges/confidence/golang-version/go/1.22.3/1.22.4?slim=true)](https://docs.renovatebot.com/merge-confidence/)
| toolchain | patch |
| golang.org/x/crypto | `v0.23.0` -> `v0.24.0` |
[![age](https://developer.mend.io/api/mc/badges/age/go/golang.org%2fx%2fcrypto/v0.24.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![adoption](https://developer.mend.io/api/mc/badges/adoption/go/golang.org%2fx%2fcrypto/v0.24.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![passing](https://developer.mend.io/api/mc/badges/compatibility/go/golang.org%2fx%2fcrypto/v0.23.0/v0.24.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![confidence](https://developer.mend.io/api/mc/badges/confidence/go/golang.org%2fx%2fcrypto/v0.23.0/v0.24.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
| require | minor |
| golang.org/x/exp | `fd00a4e` -> `fc45aab` |
[![age](https://developer.mend.io/api/mc/badges/age/go/golang.org%2fx%2fexp/v0.0.0-20240604190554-fc45aab8b7f8?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![adoption](https://developer.mend.io/api/mc/badges/adoption/go/golang.org%2fx%2fexp/v0.0.0-20240604190554-fc45aab8b7f8?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![passing](https://developer.mend.io/api/mc/badges/compatibility/go/golang.org%2fx%2fexp/v0.0.0-20240531132922-fd00a4e0eefc/v0.0.0-20240604190554-fc45aab8b7f8?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![confidence](https://developer.mend.io/api/mc/badges/confidence/go/golang.org%2fx%2fexp/v0.0.0-20240531132922-fd00a4e0eefc/v0.0.0-20240604190554-fc45aab8b7f8?slim=true)](https://docs.renovatebot.com/merge-confidence/)
| require | digest |
| golang.org/x/net | `v0.25.0` -> `v0.26.0` |
[![age](https://developer.mend.io/api/mc/badges/age/go/golang.org%2fx%2fnet/v0.26.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![adoption](https://developer.mend.io/api/mc/badges/adoption/go/golang.org%2fx%2fnet/v0.26.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![passing](https://developer.mend.io/api/mc/badges/compatibility/go/golang.org%2fx%2fnet/v0.25.0/v0.26.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![confidence](https://developer.mend.io/api/mc/badges/confidence/go/golang.org%2fx%2fnet/v0.25.0/v0.26.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
| require | minor |
| golang.org/x/tools | `v0.21.0` -> `v0.22.0` |
[![age](https://developer.mend.io/api/mc/badges/age/go/golang.org%2fx%2ftools/v0.22.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![adoption](https://developer.mend.io/api/mc/badges/adoption/go/golang.org%2fx%2ftools/v0.22.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![passing](https://developer.mend.io/api/mc/badges/compatibility/go/golang.org%2fx%2ftools/v0.21.0/v0.22.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![confidence](https://developer.mend.io/api/mc/badges/confidence/go/golang.org%2fx%2ftools/v0.21.0/v0.22.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
| require | minor |
|
[google.golang.org/genproto/googleapis/api](https://togithub.com/googleapis/go-genproto)
| `5315273` -> `ef581f9` |
[![age](https://developer.mend.io/api/mc/badges/age/go/google.golang.org%2fgenproto%2fgoogleapis%2fapi/v0.0.0-20240604185151-ef581f913117?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![adoption](https://developer.mend.io/api/mc/badges/adoption/go/google.golang.org%2fgenproto%2fgoogleapis%2fapi/v0.0.0-20240604185151-ef581f913117?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![passing](https://developer.mend.io/api/mc/badges/compatibility/go/google.golang.org%2fgenproto%2fgoogleapis%2fapi/v0.0.0-20240528184218-531527333157/v0.0.0-20240604185151-ef581f913117?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![confidence](https://developer.mend.io/api/mc/badges/confidence/go/google.golang.org%2fgenproto%2fgoogleapis%2fapi/v0.0.0-20240528184218-531527333157/v0.0.0-20240604185151-ef581f913117?slim=true)](https://docs.renovatebot.com/merge-confidence/)
| require | digest |

---

### Release Notes

<details>
<summary>aws/aws-sdk-go (github.com/aws/aws-sdk-go)</summary>

###
[`v1.53.19`](https://togithub.com/aws/aws-sdk-go/blob/HEAD/CHANGELOG.md#Release-v15319-2024-06-07)

[Compare
Source](https://togithub.com/aws/aws-sdk-go/compare/v1.53.18...v1.53.19)

\===

##### Service Client Updates

-   `service/auditmanager`: Updates service API and documentation
-   `service/b2bi`: Updates service API
-   `service/codepipeline`: Updates service API and documentation
- CodePipeline now supports overriding S3 Source Object Key during
StartPipelineExecution, as part of Source Overrides.
-   `service/sagemaker`: Updates service API and documentation
- This release introduces a new optional parameter: InferenceAmiVersion,
in ProductionVariant.
-   `service/verifiedpermissions`: Updates service API and documentation

###
[`v1.53.18`](https://togithub.com/aws/aws-sdk-go/blob/HEAD/CHANGELOG.md#Release-v15318-2024-06-06)

[Compare
Source](https://togithub.com/aws/aws-sdk-go/compare/v1.53.17...v1.53.18)

\===

##### Service Client Updates

-   `service/account`: Updates service API and documentation
-   `service/firehose`: Updates service API and documentation
- Adds integration with Secrets Manager for Redshift, Splunk,
HttpEndpoint, and Snowflake destinations
-   `service/fsx`: Updates service API and documentation
-   `service/glue`: Updates service API and documentation
- This release adds support for creating and updating Glue Data Catalog
Views.
-   `service/iotwireless`: Updates service API
- `service/location`: Updates service API, documentation, and paginators
-   `service/sns`: Updates service API and documentation
- Doc-only update for SNS. These changes include customer-reported
issues and TXC3 updates.
-   `service/sqs`: Updates service API and documentation
- Doc only updates for SQS. These updates include customer-reported
issues and TCX3 modifications.
-   `service/storagegateway`: Updates service API and documentation
- Adds SoftwareUpdatePreferences to DescribeMaintenanceStartTime and
UpdateMaintenanceStartTime, a structure which contains
AutomaticUpdatePolicy.

###
[`v1.53.17`](https://togithub.com/aws/aws-sdk-go/blob/HEAD/CHANGELOG.md#Release-v15317-2024-06-05)

[Compare
Source](https://togithub.com/aws/aws-sdk-go/compare/v1.53.16...v1.53.17)

\===

##### Service Client Updates

-   `service/globalaccelerator`: Updates service API and documentation
-   `service/glue`: Updates service API and documentation
- AWS Glue now supports native SaaS connectivity: Salesforce connector
available now
-   `service/s3`: Updates service API and examples
- Added new params copySource and key to copyObject API for supporting
S3 Access Grants plugin. These changes will not change any of the
existing S3 API functionality.

###
[`v1.53.16`](https://togithub.com/aws/aws-sdk-go/blob/HEAD/CHANGELOG.md#Release-v15316-2024-06-04)

[Compare
Source](https://togithub.com/aws/aws-sdk-go/compare/v1.53.15...v1.53.16)

\===

##### Service Client Updates

-   `service/ec2`: Updates service API
- U7i instances with up to 32 TiB of DDR5 memory and 896 vCPUs are now
available. C7i-flex instances are launched and are lower-priced variants
of the Amazon EC2 C7i instances that offer a baseline level of CPU
performance with the ability to scale up to the full compute performance
95% of the time.
-   `service/pipes`: Updates service API, documentation, and waiters
-   `service/sagemaker`: Updates service API and documentation
- Extend DescribeClusterNode response with private DNS hostname and IP
address, and placement information about availability zone and
availability zone ID.
-   `service/taxsettings`: Adds new service

###
[`v1.53.15`](https://togithub.com/aws/aws-sdk-go/blob/HEAD/CHANGELOG.md#Release-v15315-2024-06-03)

[Compare
Source](https://togithub.com/aws/aws-sdk-go/compare/v1.53.14...v1.53.15)

\===

##### Service Client Updates

-   `service/amplify`: Updates service documentation
-   `service/batch`: Updates service API and documentation
- This release adds support for the AWS Batch GetJobQueueSnapshot API
operation.
-   `service/eks`: Updates service API and documentation
-   `service/iottwinmaker`: Updates service API

</details>

<details>
<summary>minio/minio-go (github.com/minio/minio-go/v7)</summary>

###
[`v7.0.71`](https://togithub.com/minio/minio-go/releases/tag/v7.0.71):
Bugfix Release

[Compare
Source](https://togithub.com/minio/minio-go/compare/v7.0.70...v7.0.71)

#### What's Changed

- Add support for DelMarkerExpiration element by
[@&#8203;krisis](https://togithub.com/krisis) in
[https://github.com/minio/minio-go/pull/1959](https://togithub.com/minio/minio-go/pull/1959)
- feat: support tags for postPolicy Upload by
[@&#8203;jiuker](https://togithub.com/jiuker) in
[https://github.com/minio/minio-go/pull/1967](https://togithub.com/minio/minio-go/pull/1967)
- Add ListMultipartUploads mint test by
[@&#8203;klauspost](https://togithub.com/klauspost) in
[https://github.com/minio/minio-go/pull/1963](https://togithub.com/minio/minio-go/pull/1963)

**Full Changelog**:
minio/minio-go@v7.0.70...v7.0.71

</details>

<details>
<summary>golang/go (go)</summary>

###
[`v1.22.4`](https://togithub.com/golang/go/compare/go1.22.3...go1.22.4)

</details>

---

### Configuration

📅 **Schedule**: Branch creation - "before 4am on Monday" (UTC),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you
are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

👻 **Immortal**: This PR will be recreated if closed unmerged. Get
[config help](https://togithub.com/renovatebot/renovate/discussions) if
that's undesired.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Mend
Renovate](https://www.mend.io/free-developer-tools/renovate/). View
repository job log
[here](https://developer.mend.io/github/cerbos/cerbos).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4zOTMuMCIsInVwZGF0ZWRJblZlciI6IjM3LjM5My4wIiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6WyJhcmVhL2RlcGVuZGVuY2llcyIsImJvdHMiLCJraW5kL2Nob3JlIl19-->

Signed-off-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
mraerino referenced this pull request in ffddorf/terraform-backend Jun 30, 2024
[![Mend
Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
| [github.com/minio/minio-go/v7](https://togithub.com/minio/minio-go) |
`v7.0.70` -> `v7.0.72` |
[![age](https://developer.mend.io/api/mc/badges/age/go/github.com%2fminio%2fminio-go%2fv7/v7.0.72?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![adoption](https://developer.mend.io/api/mc/badges/adoption/go/github.com%2fminio%2fminio-go%2fv7/v7.0.72?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![passing](https://developer.mend.io/api/mc/badges/compatibility/go/github.com%2fminio%2fminio-go%2fv7/v7.0.70/v7.0.72?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![confidence](https://developer.mend.io/api/mc/badges/confidence/go/github.com%2fminio%2fminio-go%2fv7/v7.0.70/v7.0.72?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|

---

### Release Notes

<details>
<summary>minio/minio-go (github.com/minio/minio-go/v7)</summary>

###
[`v7.0.72`](https://togithub.com/minio/minio-go/releases/tag/v7.0.72):
Bugfix Release

[Compare
Source](https://togithub.com/minio/minio-go/compare/v7.0.71...v7.0.72)

#### What's Changed

- Keep all x-minio- headers as-is by
[@&#8203;klauspost](https://togithub.com/klauspost) in
[https://github.com/minio/minio-go/pull/1970](https://togithub.com/minio/minio-go/pull/1970)

**Full Changelog**:
minio/minio-go@v7.0.71...v7.0.72

###
[`v7.0.71`](https://togithub.com/minio/minio-go/releases/tag/v7.0.71):
Bugfix Release

[Compare
Source](https://togithub.com/minio/minio-go/compare/v7.0.70...v7.0.71)

#### What's Changed

- Add support for DelMarkerExpiration element by
[@&#8203;krisis](https://togithub.com/krisis) in
[https://github.com/minio/minio-go/pull/1959](https://togithub.com/minio/minio-go/pull/1959)
- feat: support tags for postPolicy Upload by
[@&#8203;jiuker](https://togithub.com/jiuker) in
[https://github.com/minio/minio-go/pull/1967](https://togithub.com/minio/minio-go/pull/1967)
- Add ListMultipartUploads mint test by
[@&#8203;klauspost](https://togithub.com/klauspost) in
[https://github.com/minio/minio-go/pull/1963](https://togithub.com/minio/minio-go/pull/1963)

**Full Changelog**:
minio/minio-go@v7.0.70...v7.0.71

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you
are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Mend
Renovate](https://www.mend.io/free-developer-tools/renovate/). View
repository job log
[here](https://developer.mend.io/github/ffddorf/terraform-backend).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4zMjEuMiIsInVwZGF0ZWRJblZlciI6IjM3LjQyMS4wIiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6W119-->

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants