Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add support for sso auth #1911

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Conversation

jchorl
Copy link

@jchorl jchorl commented Dec 11, 2023

This PR adds credential support for retrieving AWS SSO credentials and using those against a bucket store. I also added a test.

SSO is becoming increasingly common for many benefits. I figured I'd try a PR to support it in MinIO. I can understand if this feels too coupled with a single provider, figured I'd try anyway.

This is not a full-fledged implementation, but it works and was enough to get me off the ground running. I'm sure there are edge-cases and configs that are not covered here. I noticed that AWS sdk is not vendored in this project, so I opted to write an implementation from scratch.

@jchorl
Copy link
Author

jchorl commented Aug 24, 2024

@harshavardhana is it an explicit goal of minio not to vendor in aws libraries? They'd be really useful here to avoid reimplementing the mechanics of SSO. I noticed some activity on #1930 and was willing to pick this back up.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants