Allow build plans to be configured #187
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7003Mars
commented
Dec 10, 2023
|
Honestly, I wouldn't even bother with the BuildPlan.removed variable. It would be quite a lot of effort to make sure we are always setting removed to true and iterating plans should be relatively quick anyways (not to mention that if one additional iteration of the plans is lagging your game you almost certainly already have extremely low fps due to insane plan counts). |
|
Cursed commit history |
|
Apologies |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If your pull request is not translation or serverlist-related, read the list of requirements below and check each box:
Screen.Recording.2023-12-10.at.3.26.00.PM.mov