Eslint 9 migration #230345
Open
Eslint 9 migration #230345
+2,014
−1,955
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For #230339 Starts migrating to eslint 9. Everything runs but it produces a number of errors
mjbvz
commented
Oct 3, 2024
mjbvz
commented
Oct 3, 2024
These seem to have getting pulled in implicitly before
|
@mjbvz Pushed a change to use |
However use a different filename to avoid a warning
|
Checks look good. Build script pass and I tested introducing a few errors and confirming they were reported. Planning to merge but please keep an eye out for any regressions or cases where our custom rules no longer apply |
lramos15
approved these changes
Oct 3, 2024
|
cc @jrieken. Need your review as code owner as I touched |
Tyriar
requested changes
Oct 4, 2024
Comment on lines
+1317
to
+1319
| files: [ | ||
| 'src/vs/workbench/contrib/terminal/**/*.ts' | ||
| ], |
There was a problem hiding this comment.
Can you add 'src/vs/workbench/contrib/terminalContrib/**/*.ts' here too? You'll also need to delete it at https://github.com/microsoft/vscode/blob/main/src/vs/workbench/contrib/terminalContrib/.eslintrc.json
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #230339
Migrates us to eslint 9 and a flat config
TODO:
eslintrcfilesFollow ups:
schema: false