Add code fix for MSTEST0021 #3827
Conversation
# Conflicts: # src/Analyzers/MSTest.Analyzers.CodeFixes/CodeFixResources.Designer.cs # src/Analyzers/MSTest.Analyzers.CodeFixes/CodeFixResources.resx
|
|
||
| [TestClass] | ||
| public class MyTestClass | ||
| : IDisposable |
There was a problem hiding this comment.
this related to BaseList ready function as i tried a lot nothing there. after using the function in removing it removes the new line and in add in adds the newline
|
|
||
| await VerifyCS.VerifyAnalyzerAsync(code); | ||
| public async Task WhenTestClassHasTestCleanup_AndHasDispose_Diagnostic() |
There was a problem hiding this comment.
Are we sure about this one? what if the two bodies conflicts?
There was a problem hiding this comment.
user have to fix it, in old fix we did it like the with Amaury
| using Microsoft.VisualStudio.TestTools.UnitTesting; | ||
| using System; | ||
|
|
||
| public class LocalBase{} |
There was a problem hiding this comment.
what if this class has got a dispose?
There was a problem hiding this comment.
in all fix we were working was the first layer
| public class MyTestClass | ||
| : IDisposable | ||
| { | ||
| public void Dispose() |
There was a problem hiding this comment.
should it be virtual to allow override? https://learn.microsoft.com/en-us/dotnet/standard/garbage-collection/implementing-dispose
There was a problem hiding this comment.
but the usual fix for implementing the interface gives the not virtual one
fix: #3665