Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fixing pytest case #196

Merged
merged 2 commits into from
Oct 13, 2023
Merged

fixing pytest case #196

merged 2 commits into from
Oct 13, 2023

Conversation

saeedmaleki
Copy link
Contributor

No description provided.

Binyang2014
Binyang2014 approved these changes Oct 13, 2023
View reviewed changes
Copy link
Contributor

@Binyang2014 Binyang2014 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

chhwang
chhwang approved these changes Oct 13, 2023
View reviewed changes
Copy link
Contributor

@chhwang chhwang left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Passed unit tests: https://github.com/microsoft/mscclpp/actions/runs/6505617962
Passed integration tests: https://github.com/microsoft/mscclpp/actions/runs/6505619904

@chhwang chhwang merged commit 148681b into main Oct 13, 2023
13 of 19 checks passed
@chhwang chhwang deleted the saemal/fixing_pytest_case branch October 13, 2023 08:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chhwang chhwang chhwang approved these changes

@Binyang2014 Binyang2014 Binyang2014 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@saeedmaleki @chhwang @Binyang2014