chore: replace no-restricted-globals with @nx/workspace-no-restricted-globals in whole monorepo
#32960
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hotell
commented
Oct 1, 2024
Hotell
commented
Oct 1, 2024
Perf Analysis (
|
| Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
|---|---|---|---|---|---|
| FluentProviderWithTheme | virtual-rerender | 36 | 35 | 10 | Possible regression |
All results
| Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
|---|---|---|---|---|---|
| Avatar | mount | 686 | 658 | 5000 | |
| Button | mount | 319 | 304 | 5000 | |
| Field | mount | 1156 | 1169 | 5000 | |
| FluentProvider | mount | 718 | 730 | 5000 | |
| FluentProviderWithTheme | mount | 86 | 80 | 10 | |
| FluentProviderWithTheme | virtual-rerender | 36 | 35 | 10 | Possible regression |
| FluentProviderWithTheme | virtual-rerender-with-unmount | 76 | 75 | 10 | |
| MakeStyles | mount | 867 | 872 | 50000 | |
| Persona | mount | 1744 | 1763 | 5000 | |
| SpinButton | mount | 1399 | 1363 | 5000 | |
| SwatchPicker | mount | 1654 | 1674 | 5000 |
Perf Analysis (
|
| Scenario | Current PR Ticks | Baseline Ticks | Ratio |
|---|---|---|---|
| PortalMinimalPerf.default | 95 | 82 | 1.16:1 |
| RefMinimalPerf.default | 124 | 109 | 1.14:1 |
| AvatarMinimalPerf.default | 119 | 107 | 1.11:1 |
| ButtonMinimalPerf.default | 98 | 89 | 1.1:1 |
| RadioGroupMinimalPerf.default | 279 | 258 | 1.08:1 |
| ReactionMinimalPerf.default | 225 | 210 | 1.07:1 |
| CarouselMinimalPerf.default | 282 | 266 | 1.06:1 |
| ChatMinimalPerf.default | 461 | 433 | 1.06:1 |
| ChatWithPopoverPerf.default | 209 | 198 | 1.06:1 |
| FormMinimalPerf.default | 228 | 215 | 1.06:1 |
| ListNestedPerf.default | 347 | 327 | 1.06:1 |
| ProviderMinimalPerf.default | 210 | 199 | 1.06:1 |
| DropdownManyItemsPerf.default | 415 | 395 | 1.05:1 |
| GridMinimalPerf.default | 196 | 187 | 1.05:1 |
| TableMinimalPerf.default | 246 | 234 | 1.05:1 |
| AlertMinimalPerf.default | 166 | 159 | 1.04:1 |
| PopupMinimalPerf.default | 362 | 349 | 1.04:1 |
| SegmentMinimalPerf.default | 211 | 202 | 1.04:1 |
| ProviderMergeThemesPerf.default | 667 | 646 | 1.03:1 |
| TextMinimalPerf.default | 207 | 201 | 1.03:1 |
| TooltipMinimalPerf.default | 1352 | 1311 | 1.03:1 |
| TreeWith60ListItems.default | 93 | 90 | 1.03:1 |
| FlexMinimalPerf.default | 157 | 154 | 1.02:1 |
| ListMinimalPerf.default | 321 | 314 | 1.02:1 |
| SliderMinimalPerf.default | 734 | 723 | 1.02:1 |
| AttachmentSlotsPerf.default | 664 | 659 | 1.01:1 |
| BoxMinimalPerf.default | 193 | 191 | 1.01:1 |
| ButtonOverridesMissPerf.default | 645 | 639 | 1.01:1 |
| DropdownMinimalPerf.default | 1433 | 1418 | 1.01:1 |
| ImageMinimalPerf.default | 227 | 225 | 1.01:1 |
| LabelMinimalPerf.default | 230 | 227 | 1.01:1 |
| ListCommonPerf.default | 412 | 407 | 1.01:1 |
| MenuMinimalPerf.default | 522 | 517 | 1.01:1 |
| MenuButtonMinimalPerf.default | 982 | 976 | 1.01:1 |
| TableManyItemsPerf.default | 1142 | 1128 | 1.01:1 |
| TextAreaMinimalPerf.default | 298 | 295 | 1.01:1 |
| ToolbarMinimalPerf.default | 560 | 553 | 1.01:1 |
| AnimationMinimalPerf.default | 307 | 306 | 1:1 |
| ButtonSlotsPerf.default | 308 | 308 | 1:1 |
| CheckboxMinimalPerf.default | 1166 | 1162 | 1:1 |
| DividerMinimalPerf.default | 218 | 217 | 1:1 |
| HeaderMinimalPerf.default | 214 | 213 | 1:1 |
| LayoutMinimalPerf.default | 204 | 205 | 1:1 |
| RosterPerf.default | 1601 | 1601 | 1:1 |
| CustomToolbarPrototype.default | 1487 | 1491 | 1:1 |
| VideoMinimalPerf.default | 447 | 446 | 1:1 |
| AccordionMinimalPerf.default | 88 | 89 | 0.99:1 |
| CardMinimalPerf.default | 309 | 312 | 0.99:1 |
| DatepickerMinimalPerf.default | 3789 | 3825 | 0.99:1 |
| DialogMinimalPerf.default | 443 | 448 | 0.99:1 |
| EmbedMinimalPerf.default | 1853 | 1869 | 0.99:1 |
| TreeMinimalPerf.default | 487 | 490 | 0.99:1 |
| ItemLayoutMinimalPerf.default | 708 | 726 | 0.98:1 |
| SkeletonMinimalPerf.default | 195 | 198 | 0.98:1 |
| SplitButtonMinimalPerf.default | 2259 | 2301 | 0.98:1 |
| InputMinimalPerf.default | 530 | 545 | 0.97:1 |
| StatusMinimalPerf.default | 391 | 403 | 0.97:1 |
| ChatDuplicateMessagesPerf.default | 157 | 164 | 0.96:1 |
| HeaderSlotsPerf.default | 470 | 492 | 0.96:1 |
| IconMinimalPerf.default | 385 | 402 | 0.96:1 |
| AttachmentMinimalPerf.default | 78 | 86 | 0.91:1 |
| ListWith60ListItems.default | 349 | 385 | 0.91:1 |
| LoaderMinimalPerf.default | 184 | 204 | 0.9:1 |
Hotell
commented
Oct 1, 2024
🕵 FluentUIV0 No visual regressions between this PR and main |
📊 Bundle size report✅ No changes found |
fabricteam
reviewed
Oct 1, 2024
Perf Analysis (
|
| Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
|---|---|---|---|---|---|
| BaseButton | mount | 635 | 648 | 5000 | |
| Breadcrumb | mount | 1673 | 1779 | 1000 | |
| Checkbox | mount | 1705 | 1696 | 5000 | |
| CheckboxBase | mount | 1513 | 1482 | 5000 | |
| ChoiceGroup | mount | 2954 | 2997 | 5000 | |
| ComboBox | mount | 677 | 698 | 1000 | |
| CommandBar | mount | 6569 | 6613 | 1000 | |
| ContextualMenu | mount | 12656 | 12867 | 1000 | |
| DefaultButton | mount | 805 | 802 | 5000 | |
| DetailsRow | mount | 2186 | 2249 | 5000 | |
| DetailsRowFast | mount | 2209 | 2230 | 5000 | |
| DetailsRowNoStyles | mount | 2083 | 2106 | 5000 | |
| Dialog | mount | 2694 | 2715 | 1000 | |
| DocumentCardTitle | mount | 222 | 232 | 1000 | |
| Dropdown | mount | 2046 | 1979 | 5000 | |
| FocusTrapZone | mount | 1147 | 1161 | 5000 | |
| FocusZone | mount | 1094 | 1109 | 5000 | |
| GroupedList | mount | 42722 | 42621 | 2 | |
| GroupedList | virtual-rerender | 20312 | 20530 | 2 | |
| GroupedList | virtual-rerender-with-unmount | 51812 | 52581 | 2 | |
| GroupedListV2 | mount | 223 | 229 | 2 | |
| GroupedListV2 | virtual-rerender | 217 | 217 | 2 | |
| GroupedListV2 | virtual-rerender-with-unmount | 221 | 240 | 2 | |
| IconButton | mount | 1121 | 1104 | 5000 | |
| Label | mount | 344 | 355 | 5000 | |
| Layer | mount | 2782 | 2732 | 5000 | |
| Link | mount | 407 | 399 | 5000 | |
| MenuButton | mount | 984 | 972 | 5000 | |
| MessageBar | mount | 21430 | 21365 | 5000 | |
| Nav | mount | 2008 | 2060 | 1000 | |
| OverflowSet | mount | 799 | 803 | 5000 | |
| Panel | mount | 1829 | 1854 | 1000 | |
| Persona | mount | 747 | 744 | 1000 | |
| Pivot | mount | 905 | 908 | 1000 | |
| PrimaryButton | mount | 931 | 914 | 5000 | |
| Rating | mount | 4716 | 4749 | 5000 | |
| SearchBox | mount | 912 | 955 | 5000 | |
| Shimmer | mount | 1863 | 1920 | 5000 | |
| Slider | mount | 1321 | 1338 | 5000 | |
| SpinButton | mount | 2948 | 2936 | 5000 | |
| Spinner | mount | 396 | 398 | 5000 | |
| SplitButton | mount | 1878 | 1875 | 5000 | |
| Stack | mount | 431 | 419 | 5000 | |
| StackWithIntrinsicChildren | mount | 854 | 866 | 5000 | |
| StackWithTextChildren | mount | 2835 | 2841 | 5000 | |
| SwatchColorPicker | mount | 6367 | 6493 | 5000 | |
| TagPicker | mount | 1502 | 1448 | 5000 | |
| Text | mount | 398 | 381 | 5000 | |
| TextField | mount | 931 | 944 | 5000 | |
| ThemeProvider | mount | 873 | 847 | 5000 | |
| ThemeProvider | virtual-rerender | 582 | 584 | 5000 | |
| ThemeProvider | virtual-rerender-with-unmount | 1310 | 1274 | 5000 | |
| Toggle | mount | 594 | 631 | 5000 | |
| buttonNative | mount | 193 | 200 | 5000 |
Hotell
force-pushed
the
eslint-rules/no-restricted-globals-use-in-monorepo
branch
from
e302d63
to
fbf2142
Compare
Hotell
commented
Oct 3, 2024
apps/public-docsite-v9/src/AccessibilityScenarios/TabListOverflow.stories.tsx
Show resolved
Hide resolved
packages/react-components/react-table/library/src/hooks/useMeasureElement.ts
Show resolved
Hide resolved
🕵 fluentui-web-components-v3 No visual regressions between this PR and main |
spmonahan
approved these changes
Oct 3, 2024
apps/public-docsite-v9/src/AccessibilityScenarios/TabListOverflow.stories.tsx
Show resolved
Hide resolved
layershifter
approved these changes
Oct 3, 2024
TristanWatanabe
approved these changes
Oct 7, 2024
dmytrokirpa
approved these changes
Oct 9, 2024
Hotell
force-pushed
the
eslint-rules/no-restricted-globals-use-in-monorepo
branch
from
fbf2142
to
15e65e9
Compare
fabricteam
reviewed
Oct 9, 2024
sopranopillow
approved these changes
Oct 9, 2024
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pre-requirements
no-restricted-globalstype-aware rule #32862Previous Behavior
New Behavior
react--legacylint configuration in order to avoid enabling lint workspace rules which are intended for v9 packages etcRelated Issue(s)
no-restricted-globalseslint rule #31286