Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Release: List stable #32888

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

Release: List stable #32888

wants to merge 1 commit into from

Conversation

george-cz
Copy link
Contributor

This PR releases the List Preview to List Stable version.

Hotell
Hotell reviewed Sep 23, 2024
View reviewed changes
yarn.lock
@@ -1949,6 +1949,22 @@
"@griffel/react" "^1.5.14"
"@swc/helpers" "^0.5.1"

"@fluentui/react-list-preview@*":
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hmm this is wrong, seems the generator fixes are missing some projects that used the old -preview package and didn't replace it with the new stable one

@fabricteam
Copy link
Collaborator

🕵 fluentui-web-components-v3 No visual regressions between this PR and main

@fabricteam
Copy link
Collaborator

📊 Bundle size report

✅ No changes found

fabricteam
fabricteam reviewed Sep 23, 2024
View reviewed changes
.github/CODEOWNERS
@@ -346,9 +346,9 @@ packages/react-components/react-calendar-compat/stories @microsoft/cxe-prg
packages/react-components/react-infolabel @microsoft/cxe-prg
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🕵🏾‍♀️ visual regressions to review in the fluentuiv8 Visual Regression Report

react-charting-LineChart 1 screenshots
Image Name Diff(in Pixels) Image Type
react-charting-LineChart.Gaps.chromium.png 1 Changed

@fabricteam
Copy link
Collaborator

🕵 FluentUIV0 No visual regressions between this PR and main

@fabricteam
Copy link
Collaborator

Perf Analysis (@fluentui/react-northstar)

Perf tests with no regressions
Scenario Current PR Ticks Baseline Ticks Ratio
ButtonMinimalPerf.default 96 83 1.16:1
PortalMinimalPerf.default 90 80 1.13:1
AttachmentMinimalPerf.default 87 79 1.1:1
LoaderMinimalPerf.default 199 183 1.09:1
AvatarMinimalPerf.default 111 103 1.08:1
BoxMinimalPerf.default 203 189 1.07:1
CarouselMinimalPerf.default 268 251 1.07:1
HeaderMinimalPerf.default 219 204 1.07:1
ImageMinimalPerf.default 231 216 1.07:1
TextMinimalPerf.default 203 190 1.07:1
TooltipMinimalPerf.default 1318 1233 1.07:1
ChatMinimalPerf.default 456 431 1.06:1
DropdownManyItemsPerf.default 415 390 1.06:1
SegmentMinimalPerf.default 200 188 1.06:1
GridMinimalPerf.default 201 192 1.05:1
HeaderSlotsPerf.default 474 452 1.05:1
RadioGroupMinimalPerf.default 270 258 1.05:1
FlexMinimalPerf.default 164 157 1.04:1
AlertMinimalPerf.default 167 162 1.03:1
AnimationMinimalPerf.default 311 302 1.03:1
CardMinimalPerf.default 317 308 1.03:1
ChatDuplicateMessagesPerf.default 158 154 1.03:1
DialogMinimalPerf.default 444 433 1.03:1
LayoutMinimalPerf.default 206 200 1.03:1
ListNestedPerf.default 325 316 1.03:1
ButtonSlotsPerf.default 314 308 1.02:1
MenuButtonMinimalPerf.default 955 932 1.02:1
ProviderMergeThemesPerf.default 650 635 1.02:1
AccordionMinimalPerf.default 86 85 1.01:1
ButtonOverridesMissPerf.default 649 645 1.01:1
ChatWithPopoverPerf.default 193 192 1.01:1
DatepickerMinimalPerf.default 3621 3574 1.01:1
DividerMinimalPerf.default 213 210 1.01:1
ItemLayoutMinimalPerf.default 708 703 1.01:1
ListCommonPerf.default 388 385 1.01:1
ListMinimalPerf.default 310 307 1.01:1
PopupMinimalPerf.default 348 344 1.01:1
CustomToolbarPrototype.default 1480 1472 1.01:1
TreeWith60ListItems.default 98 97 1.01:1
FormMinimalPerf.default 219 218 1:1
ListWith60ListItems.default 366 367 1:1
TableManyItemsPerf.default 1108 1106 1:1
TableMinimalPerf.default 229 228 1:1
EmbedMinimalPerf.default 1843 1869 0.99:1
InputMinimalPerf.default 547 550 0.99:1
MenuMinimalPerf.default 499 506 0.99:1
SliderMinimalPerf.default 749 755 0.99:1
ToolbarMinimalPerf.default 543 547 0.99:1
TreeMinimalPerf.default 469 473 0.99:1
AttachmentSlotsPerf.default 622 634 0.98:1
DropdownMinimalPerf.default 1403 1433 0.98:1
ProviderMinimalPerf.default 200 204 0.98:1
ReactionMinimalPerf.default 208 212 0.98:1
SplitButtonMinimalPerf.default 2246 2284 0.98:1
StatusMinimalPerf.default 408 416 0.98:1
VideoMinimalPerf.default 419 429 0.98:1
CheckboxMinimalPerf.default 1108 1147 0.97:1
LabelMinimalPerf.default 217 224 0.97:1
RosterPerf.default 1542 1600 0.96:1
SkeletonMinimalPerf.default 192 201 0.96:1
RefMinimalPerf.default 109 115 0.95:1
IconMinimalPerf.default 384 405 0.95:1
TextAreaMinimalPerf.default 275 294 0.94:1

@fabricteam
Copy link
Collaborator

Perf Analysis (@fluentui/react-components)

No significant results to display.

All results

Scenario Render type Master Ticks PR Ticks Iterations Status
Avatar mount 629 653 5000
Button mount 305 306 5000
Field mount 1162 1132 5000
FluentProvider mount 711 723 5000
FluentProviderWithTheme mount 82 83 10
FluentProviderWithTheme virtual-rerender 36 36 10
FluentProviderWithTheme virtual-rerender-with-unmount 78 76 10
MakeStyles mount 853 876 50000
Persona mount 1744 1739 5000
SpinButton mount 1409 1454 5000
SwatchPicker mount 1675 1653 5000

fabricteam
fabricteam reviewed Sep 23, 2024
View reviewed changes
.github/CODEOWNERS
@@ -346,9 +346,9 @@ packages/react-components/react-calendar-compat/stories @microsoft/cxe-prg
packages/react-components/react-infolabel @microsoft/cxe-prg
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🕵🏾‍♀️ visual regressions to review in the fluentuiv9 Visual Regression Report

Avatar Converged 2 screenshots
Image Name Diff(in Pixels) Image Type
Avatar Converged.Badge Mask RTL.chromium.png 4 Changed
Avatar Converged.badgeMask.chromium.png 41 Changed
Drawer 2 screenshots
Image Name Diff(in Pixels) Image Type
Drawer.overlay drawer full.chromium.png 1166 Changed
Drawer.Full Overlay Dark Mode.chromium.png 2798 Changed

@fabricteam
Copy link
Collaborator

Perf Analysis (@fluentui/react)

No significant results to display.

All results

Scenario Render type Master Ticks PR Ticks Iterations Status
BaseButton mount 635 637 5000
Breadcrumb mount 1694 1696 1000
Checkbox mount 1700 1687 5000
CheckboxBase mount 1463 1486 5000
ChoiceGroup mount 2990 3021 5000
ComboBox mount 689 698 1000
CommandBar mount 6590 6604 1000
ContextualMenu mount 12778 13297 1000
DefaultButton mount 779 809 5000
DetailsRow mount 2251 2283 5000
DetailsRowFast mount 2258 2248 5000
DetailsRowNoStyles mount 2071 2054 5000
Dialog mount 2684 2881 1000
DocumentCardTitle mount 245 237 1000
Dropdown mount 2048 2007 5000
FocusTrapZone mount 1174 1141 5000
FocusZone mount 1087 1093 5000
GroupedList mount 42414 42656 2
GroupedList virtual-rerender 20462 20404 2
GroupedList virtual-rerender-with-unmount 52609 52385 2
GroupedListV2 mount 235 236 2
GroupedListV2 virtual-rerender 208 216 2
GroupedListV2 virtual-rerender-with-unmount 232 235 2
IconButton mount 1151 1173 5000
Label mount 342 340 5000
Layer mount 2805 2752 5000
Link mount 399 411 5000
MenuButton mount 984 990 5000
MessageBar mount 21728 21695 5000
Nav mount 2046 2056 1000
OverflowSet mount 811 805 5000
Panel mount 1844 1850 1000
Persona mount 737 747 1000
Pivot mount 919 899 1000
PrimaryButton mount 939 916 5000
Rating mount 4791 4709 5000
SearchBox mount 948 927 5000
Shimmer mount 1904 1936 5000
Slider mount 1316 1351 5000
SpinButton mount 3011 3017 5000
Spinner mount 401 380 5000
SplitButton mount 1950 1916 5000
Stack mount 428 431 5000
StackWithIntrinsicChildren mount 869 901 5000
StackWithTextChildren mount 2742 2826 5000
SwatchColorPicker mount 6503 6371 5000
TagPicker mount 1466 1479 5000
Text mount 384 396 5000
TextField mount 968 968 5000
ThemeProvider mount 844 872 5000
ThemeProvider virtual-rerender 589 577 5000
ThemeProvider virtual-rerender-with-unmount 1294 1302 5000
Toggle mount 601 618 5000
buttonNative mount 189 202 5000

Hotell
Hotell reviewed Sep 23, 2024
View reviewed changes
packages/react-components/react-list/stories/package.json
@@ -18,5 +18,8 @@
"@fluentui/scripts-storybook": "*",
"@fluentui/eslint-plugin": "*",
"@fluentui/scripts-tasks": "*"
},
"dependencies": {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

did you add this by hand ? there is no logic in the migration generator that would actually do this hmm

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nvm - found the bug in the generator

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Hotell Hotell Hotell left review comments

@fabricteam fabricteam fabricteam left review comments

@JustSlone JustSlone Awaiting requested review from JustSlone JustSlone will be requested when the pull request is marked ready for review JustSlone is a code owner

@jurokapsiar jurokapsiar Awaiting requested review from jurokapsiar jurokapsiar will be requested when the pull request is marked ready for review jurokapsiar is a code owner

@tudorpopams tudorpopams Awaiting requested review from tudorpopams tudorpopams will be requested when the pull request is marked ready for review tudorpopams is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@george-cz @fabricteam @Hotell