correct location of generated cert #4881
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The DSC scripts assume the certificate (specified by thumbprint) is in the localmachine store, not current user. Corrections to help output regarding use of both CertificatePath and CreateSelfSigned params.
| @@ -1714,7 +1714,7 @@ function Update-M365DSCAzureAdApplication | |||
| if ($CreateSelfSignedCertificate) | |||
| { | |||
| Write-LogEntry ' CreateSelfSignedCertificate specified, generating new Self Signed Certificate' | |||
| $cerCert = New-SelfSignedCertificate -CertStoreLocation 'Cert:\CurrentUser\My' ` | |||
| $cerCert = New-SelfSignedCertificate -CertStoreLocation 'Cert:\LocalMachine\My' ` | |||
There was a problem hiding this comment.
This part depends on what the intent is. If the user wants to do an Export, than the CurrentUser store is where the certificate should be placed. If it's a logic path using the LCM (e.g., Start/Test-DSCConfiguration) then LocalMachine is required.
There was a problem hiding this comment.
but currently it does neither an export-pfx nor places it in a store for subsequent use. So as a new user, I cannot use this scriptlet to configure a service principal for me.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The DSC scripts assume the certificate (specified by thumbprint) is in the localmachine store, not current user. Corrections to help output regarding use of both CertificatePath and CreateSelfSigned params.
Pull Request (PR) description
This PR addresses the above issues by generating the cert in the LocalMachine store and correcting the parameter comments.
This Pull Request (PR) fixes the following issues