support multiple lines in devcontainer action #4192
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Updated the action to create a temporary script file for the command execution, ensuring the script name is in lowercase. - Changed the command execution from directly passing the command to using the generated script file. - Cleaned up the temporary script file after execution. - Updated workflow files to use a multiline string for the COMMAND input, improving readability. This change enhances the handling of commands in the DevContainer action and maintains a cleaner environment post-execution.
guybartal
requested review from
Copilot,
tamirkamara and
marrobi
and removed request for
Copilot
There was a problem hiding this comment.
Copilot reviewed 2 out of 2 changed files in this pull request and generated no suggestions.
Unit Test Results0 tests 0 ✅ 0s ⏱️ Results for commit ddf1cc0. ♻️ This comment has been updated with latest results. |
|
@guy has this been tested end to end? If so can you post a link to the run? Thanks. |
yuvalyaron
approved these changes
Dec 12, 2024
|
/test |
|
🤖 pr-bot 🤖 🏃 Running tests: https://github.com/microsoft/AzureTRE/actions/runs/12355453987 (with refid (in response to this comment from @guybartal) |
marrobi
reviewed
Dec 16, 2024
There was a problem hiding this comment.
@guybartal , @tamirkamara has said he will review this prior to being merged. Please await his review! Thanks.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support multiple lines in devcontainer action
Before this PR CI workflow developers could only code commands in a single line (inline) to run inside devcontainer,
this becomes challenging to code complex scenarios and maintain it overtime as it is less readable.
This PR introduces a way to embed multiple shell command lines which are more readable and maintainable,
this inline script then materializes into a temp unique shell file which is mounted as
command.shfile inside the workspace path.