Support dynamic resource suffix in Airlock

[yuvalyaron]

Resolves #3237

What is being addressed

• The code in the airlock processor references certain storage accounts by assuming that their names have the workspace short ID as a suffix. Rather than making this assumption, the suffix was changed to be passed in the 'status changed' message.

• Added Migration to add the unique_identifier_suffix field to all resources. As the changes in Workspace deploy fails because storage account is not unique #2893 expect this field to exist in all resources. The value that the migration is adding is the last 4 digits of the resource as this was the value that we used before the changes.

How is this addressed

• Added migration to add the unique_identifier_suffix field.
• Replaced workspace ID with unique_identifier_suffix in airlock processor
• Fixed unit tests

[github-actions]

Unit Test Results

617 tests   608 ✅  8s ⏱️
  2 suites    2 💤
  2 files      7 ❌

For more details on these failures, see this check.

Results for commit 736233c.

♻️ This comment has been updated with latest results.

[tamirkamara]

Across much of this change, isn't the unique_identifier_suffix always the workspace one?
If so, shouldn't we call it like that?

[yuvalyaron]

changed

[eladiw]

Lgtm

[marrobi]

@yuvalyaron @tamirkamara can you recall where this got to? We are hitting some storage account name conflicts on the airlock accounts...

import_approved_storage_name = lower(replace("stalimapp${substr(local.workspace_resource_name_suffix, -8, -1)}", "-", ""))

This needs to include say the tre_id to reduce the risk of a conflict.

[tamirkamara]

@yuvalyaron @tamirkamara can you recall where this got to? We are hitting some storage account name conflicts on the airlock accounts...

import_approved_storage_name = lower(replace("stalimapp${substr(local.workspace_resource_name_suffix, -8, -1)}", "-", ""))

This needs to include say the tre_id to reduce the risk of a conflict.

This PR depends on another large development we paused for now. It looks for a workspace property that notes the random suffix of resource names like the storage accounts.
So this PR specifically should remain agnostic to what value is chosen for that suffix.