[ADD] Add primary phone number to form view #28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Got it, thanks!
|
amh-mw
force-pushed
the
15.0
branch
2 times, most recently
from
2677300
to
9f92494
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@amh-mw
As asked (per email), this one was not added to PR yet, but it's ready. I tried to send a message in Jira but I couldn't.
To test:
The Primary Phone selection field is only visible on Edit mode. The Primary Phone computed field is readonly and only visible when a Primary phone is selected and there is a value to it. If mobile/phone are empty, this field is not visible.
Some corrections on a few files were not added by me. I removed and they were re-added automatically, but there is no change on functionally done by these corrections so I hope it's not a problem.