HCP for android emulator #87
Conversation
There was a problem hiding this comment.
Great, thank you for this PR.
Let me check if I understand the problem, you are saying that running in the Android emulator HCP is not working and then the app code is not getting new versions after changes? I always test on devices then I would be glad to understand the issue better.
src/android/AssetBundle.java
Outdated
| @@ -191,7 +191,7 @@ public String getRootUrlString() { | |||
| JSONObject runtimeConfig = getRuntimeConfig(); | |||
| if (runtimeConfig != null) { | |||
| try { | |||
| rootUrlString = runtimeConfig.getString("ROOT_URL"); | |||
| rootUrlString = runtimeConfig.getString("ROOT_URL").replace("localhost","10.0.2.2"); | |||
There was a problem hiding this comment.
A few suggestions:
1 - Could you split this operation into two lines (not replacing directly after getString) to improve readability;
2 - Extract these string localhost and 10.0.2.2 for constants then we can have a readable name for both;
3 - I don't remember if we have the environment available in the Java part but it would be good to only apply this replace in development mode.
There was a problem hiding this comment.
Yep, HCP doesn't work in Android emulator without this. That's the only purpose of it, is to make HCP work in Android emulator.
The proposed change is a straight steal from this existing meteor code, which is solving the same problem:
I can split the lines for readability and extract the strings as constants, but I don't know what the test would be for whether it's dev or not. Is there a standard test for that? I'm pretty sure it already can only impact dev, because the server won't be localhost in production.
There was a problem hiding this comment.
hm ok, if Meteor is already doing the same I believe this is safe. Please just update your code to have constants and let's move this forward.
There was a problem hiding this comment.
cool -- I extracted the constants and split the line into two.
|
This travis build is failing for a reason unrelated to the change. The change is in Android-only java code, but the build is failing because it can't find the iPhone 11 Pro Max. |
|
Hello @RealHandy, we both took the same path to solve this problem. And as I haven't seen your PR before I end up opening the #93 issue to address this. In the end, I came to the conclusion that we don't have a real bug in Meteor but a lack of clearer documentation that points to Additionally our That's why I believe this PR shouldn't be merged, but I encourage anyone to submit a PR to meteor docs and add this caveat. I might do this in the future but feel free to do it first. |
I'm not sure we're addressing the same issue. This PR is only to deal with debugging in emulator, because when debugging in emulator "localhost" means the machine running the emulator, not the emulator itself, so to debug the emulator, you have to declare 10.0.2.2 instead. You probably know all that. But this doesn't come into play at all when using a real device. It's strictly to debug on an emulator. It sounds like your issue has also to do with real devices in some way, which on the surface, sounds outside the bounds of this change. Maybe? |
I made this change to get HCP to work in the android emulator. I think it's safe, given that it doesn't do anything unless this is android and "localhost" is present in the ROOT_URL string, which means it has to be the emulator -- right? The idea was taken straight from code that runs elsewhere that deals with the 10.0.2.2 android issue.