Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/4060 gantt working hours #6149

Draft
wants to merge 13 commits into
base: develop
Choose a base branch
from

Conversation

80avin
Copy link

@80avin 80avin commented Dec 23, 2024

📑 Summary

Brief description about the content of your PR.

Resolves #4060

📏 Design Decisions

Describe the way your implementation works or what design decisions you made if applicable.

📋 Tasks

Make sure you

  • 📖 have read the contribution guidelines
  • 💻 have added necessary unit/e2e tests.
  • 📓 have added documentation. Make sure MERMAID_RELEASE_VERSION is used for all new features.
  • 🦋 If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpm changeset and following the prompts. Changesets that add features should be minor and those that fix bugs should be patch. Please prefix changeset messages with feat:, fix:, or chore:.

Copy link

changeset-bot bot commented Dec 23, 2024

⚠️ No Changeset found

Latest commit: 6f32ce1

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions github-actions bot added the Type: Enhancement New feature or request label Dec 23, 2024
Copy link

netlify bot commented Dec 23, 2024

Deploy Preview for mermaid-js ready!

Name Link
🔨 Latest commit 6f32ce1
🔍 Latest deploy log https://app.netlify.com/sites/mermaid-js/deploys/676951e633e7df000808d1b6
😎 Deploy Preview https://deploy-preview-6149--mermaid-js.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

pkg-pr-new bot commented Dec 23, 2024

Open in Stackblitz

npm i https://pkg.pr.new/mermaid-js/mermaid@6149
npm i https://pkg.pr.new/mermaid-js/mermaid/@mermaid-js/layout-elk@6149
npm i https://pkg.pr.new/mermaid-js/mermaid/@mermaid-js/mermaid-zenuml@6149
npm i https://pkg.pr.new/mermaid-js/mermaid/@mermaid-js/parser@6149

commit: 6f32ce1

Copy link

codecov bot commented Dec 23, 2024

Codecov Report

Attention: Patch coverage is 84.21053% with 12 lines in your changes missing coverage. Please review.

Project coverage is 4.59%. Comparing base (df636c6) to head (6f32ce1).

Files with missing lines Patch % Lines
packages/mermaid/src/diagrams/gantt/ganttDb.js 84.21% 12 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           develop   #6149      +/-   ##
==========================================
+ Coverage     4.48%   4.59%   +0.10%     
==========================================
  Files          383     383              
  Lines        54038   54110      +72     
  Branches       596     605       +9     
==========================================
+ Hits          2425    2486      +61     
- Misses       51613   51624      +11     
Flag Coverage Δ
unit 4.59% <84.21%> (+0.10%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
packages/mermaid/src/diagrams/gantt/ganttDb.js 78.06% <84.21%> (+0.58%) ⬆️

@80avin 80avin force-pushed the feature/4060_gantt-working-hours branch 2 times, most recently from b699627 to 55be90b Compare December 23, 2024 12:00
@80avin 80avin force-pushed the feature/4060_gantt-working-hours branch from 55be90b to 6f32ce1 Compare December 23, 2024 12:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Configure Gantt diagram to use specific day hours
3 participants