-
-
Notifications
You must be signed in to change notification settings - Fork 6.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding animations to flowchart edges also fixing bug with invisible edges #6136
base: develop
Are you sure you want to change the base?
Conversation
🦋 Changeset detectedLatest commit: ec0d9c3 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
✅ Deploy Preview for mermaid-js ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
commit: |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #6136 +/- ##
==========================================
- Coverage 4.48% 4.47% -0.01%
==========================================
Files 383 382 -1
Lines 54038 54131 +93
Branches 596 621 +25
==========================================
Hits 2425 2425
- Misses 51613 51706 +93
Flags with carried forward coverage won't be shown. Click here to find out more.
|
📑 Summary
Brief description about the content of your PR.
Resolves #5813 #5574
📏 Design Decisions
Proposing a new syntax for this. The key thing is to be able to attach an id the edge. After trhat we use the same syntax for edges as we have to add additional info to a node.
Easiest case:
Selecting type of animation
V1 will support 2,
fast
andslow
This is a shorthand for
{ animate: true, animation: fast}
classDef statements
You can also add animations using classDef statements
Note the escaped comma in the dasharray. This is because ',' is used as a delimiter between styles mermaid.
📋 Tasks
Make sure you
MERMAID_RELEASE_VERSION
is used for all new features.pnpm changeset
and following the prompts. Changesets that add features should beminor
and those that fix bugs should bepatch
. Please prefix changeset messages withfeat:
,fix:
, orchore:
.