Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: some demo ELK plugin imports and loads #6045

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

kairi003
Copy link
Contributor

@kairi003 kairi003 commented Nov 10, 2024

📑 Summary

Fix some demo ELK plugin imports and loads.
In particular, it fixes an issue where http://localhost:9000/dev/example.html would crash.

📏 Design Decisions

This method can be found in the repository by searching for the word: mermaid-layout-elk.esm.mjs.

-      import flowchartELK from './mermaid-flowchart-elk.esm.mjs';
-      await mermaid.registerExternalDiagrams([flowchartELK]);
+      import layouts from './mermaid-layout-elk.esm.mjs';
+      mermaid.registerLayoutLoaders(layouts);

📋 Tasks

This PR does not change any application code.

Copy link

changeset-bot bot commented Nov 10, 2024

⚠️ No Changeset found

Latest commit: 56f7bfb

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions github-actions bot added the Type: Other Not an enhancement or a bug label Nov 10, 2024
Copy link

netlify bot commented Nov 10, 2024

Deploy Preview for mermaid-js ready!

Name Link
🔨 Latest commit 56f7bfb
🔍 Latest deploy log https://app.netlify.com/sites/mermaid-js/deploys/6730c953b2d90c0008e4e178
😎 Deploy Preview https://deploy-preview-6045--mermaid-js.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

pkg-pr-new bot commented Nov 10, 2024

Open in Stackblitz

pnpm add https://pkg.pr.new/mermaid-js/mermaid@6045
pnpm add https://pkg.pr.new/mermaid-js/mermaid/@mermaid-js/mermaid-zenuml@6045
pnpm add https://pkg.pr.new/mermaid-js/mermaid/@mermaid-js/layout-elk@6045
pnpm add https://pkg.pr.new/mermaid-js/mermaid/@mermaid-js/parser@6045

commit: 56f7bfb

Copy link

codecov bot commented Nov 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 4.49%. Comparing base (c8ce416) to head (56f7bfb).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           develop   #6045   +/-   ##
=======================================
  Coverage     4.49%   4.49%           
=======================================
  Files          383     383           
  Lines        53925   53925           
  Branches       596     596           
=======================================
  Hits          2425    2425           
  Misses       51500   51500           
Flag Coverage Δ
unit 4.49% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Copy link

argos-ci bot commented Nov 10, 2024

The latest updates on your projects. Learn more about Argos notifications ↗︎

Build Status Details Updated (UTC)
default (Inspect) ✅ No changes detected - Nov 10, 2024, 3:08 PM

@kairi003 kairi003 force-pushed the chore/fix_demos_import_elk branch from edb7225 to 144314a Compare November 10, 2024 14:52
@kairi003 kairi003 force-pushed the chore/fix_demos_import_elk branch from 144314a to 56f7bfb Compare November 10, 2024 14:55
@kairi003 kairi003 changed the title fix: some demo elk plugin imports Fix some demo ELK plugin imports and loads. Nov 10, 2024
@kairi003 kairi003 changed the title Fix some demo ELK plugin imports and loads. Fix some demo ELK plugin imports and loads Nov 10, 2024
@kairi003 kairi003 changed the title Fix some demo ELK plugin imports and loads fix: some demo ELK plugin imports and loads Nov 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Other Not an enhancement or a bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant