-
-
Notifications
You must be signed in to change notification settings - Fork 6.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: allow to put notes in namespaces on classDiagram #5814
base: develop
Are you sure you want to change the base?
feat: allow to put notes in namespaces on classDiagram #5814
Conversation
🦋 Changeset detectedLatest commit: 2dd29be The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
✅ Deploy Preview for mermaid-js ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #5814 +/- ##
==========================================
- Coverage 5.01% 5.01% -0.01%
==========================================
Files 336 336
Lines 48073 48105 +32
Branches 575 575
==========================================
Hits 2413 2413
- Misses 45660 45692 +32
Flags with carried forward coverage won't be shown. Click here to find out more.
|
The latest updates on your projects. Learn more about Argos notifications ↗︎
|
c8a41d6
to
fc0c793
Compare
commit: |
📑 Summary
It improve its support for notes inside namespaces.
Resolves #4706
📏 Design Decisions
It allows NoteNode to be added in the namespace.
classStatements
parses not onlyclassStatement
but alsonoteStatement
and returns an array of their IDs.addClassesToNamespace()
takes a new paramnoteNames
and associates the namespace with the note.classRender-v2.ts
addNotes()
implements the process of adding to namespace likeaddClasses()
.notes
fromArray
toClassNoteMap
.ClassNote
.📋 Tasks
Make sure you
MERMAID_RELEASE_VERSION
is used for all new features.pnpm changeset
and following the prompts. Changesets that add features should beminor
and those that fix bugs should bepatch
. Please prefix changeset messages withfeat:
,fix:
, orchore:
.