Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: screenpipe support in china #415

Merged
merged 1 commit into from
Oct 8, 2024
Merged

Conversation

neo773
Copy link
Contributor

@neo773 neo773 commented Oct 3, 2024

This PR fixes hugging face being blocked in China.
User can specify env variable HF_ENDPOINT=https://hf-mirror.com for CLI to use China mirror

type of change

  • bug fix (non-breaking change which fixes an issue)

/claim #341
/closes #341

Copy link

vercel bot commented Oct 3, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
screenpipe ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 3, 2024 2:16am

@louis030195
Copy link
Collaborator

@neo773 i think we download stuff from other places like github

#383 -> prob this would need a hack for china too (e.g. host some ffmpeg build on chinese-friendly data center), but can do later

@neo773
Copy link
Contributor Author

neo773 commented Oct 7, 2024

Github is not banned in China only hugging-face

@neo773
Copy link
Contributor Author

neo773 commented Oct 7, 2024

Tested the ffmpeg URL with this website, it's not blocked https://www.comparitech.com/privacy-security-tools/blockedinchina/

@louis030195
Copy link
Collaborator

/approve

thank you :)

Copy link

algora-pbc bot commented Oct 8, 2024

@louis030195: The claim has been successfully added to reward-all. You can visit your dashboard to complete the payment.

@louis030195 louis030195 merged commit 2120357 into mediar-ai:main Oct 8, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

screenpipe support in china
2 participants