Implement new drag-and-drop engine #598
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…opContext component
…anges result in UI changes
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
chrisvxd
commented
Sep 6, 2024
| setDragAxis("dynamic"); | ||
| } else { | ||
| setDragAxis("y"); | ||
| } |
There was a problem hiding this comment.
How does this work if the item is dragged between dropzones with drag axes?
chrisvxd
added a commit
that referenced
this pull request
Sep 7, 2024
This will result in duplicate history entries if the item has a resolveData method. This is difficult to prevent without a deferredDispatch method, similar to that being explored in #598.
chrisvxd
added a commit
that referenced
this pull request
Sep 7, 2024
This will result in duplicate history entries if the item has a resolveData method. This is difficult to prevent without a deferredDispatch method, similar to that being explored in #598.
chrisvxd
added a commit
that referenced
this pull request
Sep 7, 2024
This will result in duplicate history entries if the item has a resolveData method. This is difficult to prevent without a deferredDispatch method, similar to that being explored in #598.
chrisvxd
added a commit
that referenced
this pull request
Sep 9, 2024
This will result in duplicate history entries if the item has a resolveData method. This is difficult to prevent without a deferredDispatch method, similar to that being explored in #598.
chrisvxd
added a commit
that referenced
this pull request
Sep 9, 2024
This will result in duplicate history entries if the item has a resolveData method. This is difficult to prevent without a deferredDispatch method, similar to that being explored in #598.
Works on mobile and doesn't conflict with dnd-kit setPointerCapture bugfix, which is necessary to ensure reparenting on mobile devices don't break pointer tracking.
|
@chrisvxd This sounds very exciting. Dnd kit will really be a good upgrade. May I know, if there are any estimates of when this will be ready to use. Both stable and beta version of it. |
Also catches an edge-case where ref is the same
The drag would start before draggedItem existed, making it possible to drag an item into a disallowed DropZone.
|
Thanks @princebansal - we don't have a timeline yet. It's slow progress as it's a non-trivial implementation. I would like to get it out by end of October in v0.17, but that's not based on anything! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement new drag-and-drop engine using the experimental dnd-kit release.
This is a work-in-progress. Commits and code will be tidied up before finalising. It relies on upstream changes to dnd-kit (which have not yet been pushed anywhere).
Features
Still to do