Draft: angular 18 #170
Open
Draft: angular 18 #170
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BREAKING CHANGE: This requires `@angular/*>=18.0.0`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've tried migrating this repository to Angular 18. Please check that the result works as expected, I am not sure what the test cover. As far as I could tell, not too much. I will try and build + test it with another project that uses MDB. But that will for sure not cover all components.
I've added a simple Node.js GitHub build to prove it: https://github.com/bbortt/mdb-angular-ui-kit/actions/runs/10387235847/job/28760275719.
Closes #169.
Not sure who should review it. Maybe @idzark?