Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add WORDPRESS_HOST heroku config var #72

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

martinandert
Copy link

This, together with WORDPRESS_VERSION, allows the buildpack to download a pre-localized Wordpress version. The default setting for WORDPRESS_HOST is "wordpress.org".

Example:

heroku config:set WORDPRESS_HOST=de.wordpress.org
heroku config:set WORDPRESS_VERSION=3.9.1-de_DE

This will download Wordpress from http://de.wordpress.org/wordpress-3.9.1-de_DE.tar.gz

@okko
Copy link
Collaborator

okko commented Jun 3, 2014

Thanks for contributing!

Based on my experience there's no point in downloading a different language version of WordPress. The core is same in all languages and the buildpack only uses the core. Language-dependant stuff is in wp-content that is not provided by the buildpack. The documentation in this pull request is thus a bit misleading. Specifying an alternative host for downloading might be okay, would you like to update the documentation to only instruct WORDPRESS_HOST as a configuration param and not tie the version to it?

It would also be good to prefix all buildpack settings with "BUILDPACK_", so WORDPRESS_HOST could/should be BUILDPACK_WORDPRESS_HOST. We might migrate the other vars to this scheme later, I haven't discussed this yet with @mchung. Especially the current buildpack variable "S3_BUCKET" can collide with a bucket setting of the production site, but this is a separate discussion.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants