port sqlcipher to go-sqlite3 #622
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattn
reviewed
Aug 30, 2018
_example/simple/simple.go
Outdated
| @@ -3,7 +3,7 @@ package main | |||
| import ( | |||
| "database/sql" | |||
| "fmt" | |||
| _ "github.com/mattn/go-sqlite3" | |||
| _ "github.com/CovenantSQL/go-sqlite3-encrypt" | |||
mattn
reviewed
Aug 30, 2018
README.md
Outdated
| [](https://travis-ci.org/mattn/go-sqlite3) | ||
| [](https://coveralls.io/r/mattn/go-sqlite3?branch=master) | ||
| [](https://goreportcard.com/report/github.com/mattn/go-sqlite3) | ||
| [](http://godoc.org/github.com/CovenantSQL/go-sqlite3-encrypt) |
mattn
reviewed
Aug 30, 2018
README.md
Outdated
| @@ -46,14 +49,32 @@ Supported Golang version: | |||
|
|
|||
| This package can be installed with the go get command: | |||
|
|
|||
| go get github.com/mattn/go-sqlite3 | |||
| go get github.com/CovenantSQL/go-sqlite3-encrypt | |||
There was a problem hiding this comment.
I changed that just in case you dont want to merge my pr.
so, any other modify I need to do?
|
You have better to work on $GOPATH/src/github.com/mattn/go-sqlite3 with branch not on $GOPATH/src/github.com/CovenantSQL/go-sqlite3-encrypt. |
auxten
changed the title
|
@gjrtimmer How do you think this PR? |
|
FYI https://github.com/xeodou/go-sqlcipher is basically what is described in this PR (I can't speak for the code though, haven't read it) |
|
any progress ? |
you can just use my fork version. |
Looking into it |
|
Any updates? |
|
I have created the following PR to allow using SQLCipher with go-sqlite3, which I believe supersedes this one: #1109 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
hi mattn:
I ported sqlcipher to go-sqlite3 and just made it work, I knew that the PR is mess up, here are what i did:
I don't know weather you are willing to add this feature. if it is, I will do some clean up and make the PR decent. here is a list i am willing to do, and any advise is welcome :)