Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

preupdate_hook: move convertAssign code to preupdate_hook file #1156

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

charlievieth
Copy link
Contributor

Move the convertAssign logic from convert.go to
sqlite3_opt_preupdate_hook.go since that is the
only place it is used.

Copy link
Contributor

@dolmen dolmen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What about just adding the build tags to convert.go?

//go:build sqlite_preupdate_hook
// +build sqlite_preupdate_hook

@charlievieth
Copy link
Contributor Author

What about just adding the build tags to convert.go?

//go:build sqlite_preupdate_hook
// +build sqlite_preupdate_hook

That's also a valid solution. My motivation for moving it to sqlite3_opt_preupdate_hook.go is that it is a relatively small file, it's nice to consolidate logic, and most of the file names match their respective build tags so I felt that it would be clearer / more consistent to move it there.

Move the convertAssign logic from convert.go to
sqlite3_opt_preupdate_hook.go since that is the
only place it is used.
@charlievieth
Copy link
Contributor Author

@dolmen could you take another look at this PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants