Get back to Recovering syncing when we haven't sync for a while #3995
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3995 +/- ##
=======================================
Coverage 84.67% 84.68%
=======================================
Files 269 269
Lines 28753 28767 +14
=======================================
+ Hits 24348 24361 +13
- Misses 4405 4406 +1 ☔ View full report in Codecov by Sentry. |
MatMaul
force-pushed
the
recovering
branch
3 times, most recently
from
4f08a1f
to
0b79ccb
Compare
MatMaul
force-pushed
the
recovering
branch
2 times, most recently
from
a1419c3
to
e3d754b
Compare
MatMaul
force-pushed
the
recovering
branch
4 times, most recently
from
26c8a43
to
6087d41
Compare
Mainly that last refactor introduced an error somewhere since it seems to break a lot of tests 😅 https://github.com/matrix-org/matrix-rust-sdk/actions/runs/11217272471/job/31178453216?pr=3995 I just tried a revert and tests are back to green (outside of coverage). I can't really figure out why this is happening so if you can have a look that would be neat. |
| /// The current state of the `RoomListService`. | ||
| current: SharedObservable<State>, | ||
|
|
||
| last_sync_date: Instant, |
There was a problem hiding this comment.
This value is never updated. I'm working on it :-).
| @@ -83,6 +127,8 @@ impl State { | |||
| } | |||
| }; | |||
|
|
|||
| self.set(next_state.clone()); | |||
There was a problem hiding this comment.
This is the error that makes test_sliding_sync_indicator to fail, and possibly other tests. This method caculates the next state, but the state must be updated if and only if a sync has run. It's RoomListService::sync that is responsible to update the state.
|
I've pushed tchapgouv#2, it's a patch on your branch. If you merge it, I think this patch should pass all the tests. Please, rebase all commits into a single one. |
Fixes #3935.
Untested in the apps for now, but integration test is included and working.
Signed-off-by: Mathieu Velten [email protected]