sdk: Add support for authenticated media stable feature #3961
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3961 +/- ##
==========================================
+ Coverage 84.17% 84.20% +0.03%
==========================================
Files 267 267
Lines 28181 28195 +14
==========================================
+ Hits 23720 23742 +22
+ Misses 4461 4453 -8 ☔ View full report in Codecov by Sentry. |
zecakeh
force-pushed
the
auth-media-stable-feature
branch
from
c9f2741
to
063d3cf
Compare
Was added post-merge to the MSC for servers that support authenticated media but do not support all of Matrix 1.11 yet. Signed-off-by: Kévin Commaille <[email protected]>
zecakeh
force-pushed
the
auth-media-stable-feature
branch
from
063d3cf
to
02751ca
Compare
Hywan
requested changes
Sep 9, 2024
|
I don't see how we can assert that directly, everything happens inside that one call to the method. It is asserted indirectly by the fact that it uses the authenticated media endpoint. |
|
@Hywan, maybe you can clarify what you meant, if it is blocking the review? |
|
Hmm, it seems fine actually, I don't remember exactly what I was referring to. I'm approving and merging this PR. |
Hywan
approved these changes
Oct 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Was added post-merge to the MSC in matrix-org/matrix-spec-proposals#4180 for servers that support authenticated media but do not support all of Matrix 1.11 yet.
Requires a kind of hack to force Ruma to select the stable endpoint by ignoring the real versions advertised by the homeserver for this particular endpoint.