Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend fed client interface for complement usage #415

Merged
merged 1 commit into from
Sep 21, 2023
Merged

Conversation

devonh
Copy link
Contributor

@devonh devonh commented Sep 21, 2023

No description provided.

@codecov
Copy link

codecov bot commented Sep 21, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (095d10f) 58.68% compared to head (50a984a) 58.68%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #415   +/-   ##
=======================================
  Coverage   58.68%   58.68%           
=======================================
  Files          51       51           
  Lines        7062     7062           
=======================================
  Hits         4144     4144           
  Misses       2529     2529           
  Partials      389      389           
Files Changed Coverage Δ
fclient/federationclient.go 11.55% <ø> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@kegsay kegsay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but surely we need a concrete impl of these functions somewhere in GMSL too?

@devonh
Copy link
Contributor Author

devonh commented Sep 21, 2023

LGTM, but surely we need a concrete impl of these functions somewhere in GMSL too?

They already exist, we just weren't exposing them in the interface since Dendrite must not use them.

@devonh devonh merged commit 0466775 into main Sep 21, 2023
7 checks passed
@devonh devonh deleted the complement-update branch September 21, 2023 17:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants