Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove superfluous slashes in reg exps #1134

Open
wants to merge 1 commit into
base: refactor/ownProperties
Choose a base branch
from
Open

Remove superfluous slashes in reg exps #1134

wants to merge 1 commit into from

Conversation

zorkow
Copy link
Member

@zorkow zorkow commented Sep 30, 2024

Remove superfluous slashes from all regular expressions. There is still one bizarre escape character error here:

ts/input/mathml/mml3/mml3.ts:691:13: Unnecessary escape character: \<. [Error/no-useless-escape]

@zorkow zorkow requested a review from dpvc September 30, 2024 13:08
@dpvc
Copy link
Member

dpvc commented Sep 30, 2024

There is still one bizarre escape character error here

That should probably be \\ rather than just \, as it is in a sting literal.

dpvc
dpvc approved these changes Sep 30, 2024
View reviewed changes
Copy link
Member

@dpvc dpvc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I think making the \ into \\ will fix the other message.

@zorkow
Copy link
Member Author

zorkow commented Sep 30, 2024

Looks good. I think making the \ into \\ will fix the other message.

Turns out that the entire case does not work. See PR #1136 for a fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dpvc dpvc dpvc approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zorkow @dpvc