Add git hooks for commit and push #1130
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR adds
githooks forcommitandpush. The hooks are run by husky. Currently the hooks are setup as follows:pre-commitruns lint-staged that applies lifecycle scripts to staged files, restages the files and commits. It blocks the commit if the lifecycle scripts fail or would result in an empty commit. Right now I have only addedpnpm format:fix. Once the code base is fully linted we should also addpnpm lint:fix.pre-pushshould run the test suite. But I've committed them out for the time being as this can be pretty annoying...