Develop #1051
Open
Develop #1051
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Fix lint error and tests:
Opened todo should have different icon: Feel free to ask for help in the chat if you need 🙂 |
TarasHoliuk
suggested changes
Sep 30, 2024
src/App.tsx
Outdated
|
|
||
| setTodos(todos); | ||
| } catch (error) { | ||
| console.error('Error loading todos:', error); |
There was a problem hiding this comment.
disable lint rule or handle error in different way
src/App.tsx
Outdated
| useEffect(() => { | ||
| const fetchTodos = async () => { | ||
| try { | ||
| const todos = await getTodos(); |
There was a problem hiding this comment.
Suggested change
| const todos = await getTodos(); | |
| const fetchedTodos = await getTodos(); |
to avoid lint error
src/App.tsx
Outdated
Comment on lines
15
to
16
| const searchQuery = useSelector((state: RootState) => state.filter.query); | ||
| const status = useSelector((state: RootState) => state.filter.status); |
There was a problem hiding this comment.
Suggested change
| const searchQuery = useSelector((state: RootState) => state.filter.query); | |
| const status = useSelector((state: RootState) => state.filter.status); | |
| const { searchQuery, status } = useSelector((state: RootState) => state.filter); |
src/App.tsx
Outdated
| fetchTodos(); | ||
| }, []); | ||
|
|
||
| const filteredTodos = todos.filter(todo => { |
| return matchesQuery && matchesStatus; | ||
| }); | ||
|
|
||
| const handleTodoClick = (todo: Todo) => { |
There was a problem hiding this comment.
redundant function wrapper, just use setSelectedTodo everywhere instead
| reducers: {}, | ||
| reducers: { | ||
| setSearchQuery: (state, action) => { | ||
| state.query = action.payload; |
There was a problem hiding this comment.
disable this rule for the entire file
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DEMO LINK