solution #1044
Open
solution #1044
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BudnikOleksii
suggested changes
Sep 30, 2024
src/App.tsx
Outdated
Comment on lines
16
to
17
| const todos = useAppSelector(state => state.todos); | ||
| const currentTodo = useAppSelector(state => state.currentTodo); |
There was a problem hiding this comment.
It's better to create selectors so you can reuse them
https://redux.js.org/usage/deriving-data-selectors
src/App.tsx
Outdated
| const dispatch = useDispatch(); | ||
| const todos = useAppSelector(state => state.todos); | ||
| const currentTodo = useAppSelector(state => state.currentTodo); | ||
| const [loader, setLoader] = useState(false); |
There was a problem hiding this comment.
Boolean variables should start from is or has
src/components/TodoList/TodoList.tsx
Outdated
Comment on lines
19
to
21
| const filteredTodos = todos | ||
| .filter(todo => { | ||
| if (status === Status.Active) { |
There was a problem hiding this comment.
- Create a separate function and move it to utils/helpers folder
- if there are no query and status is all you don't need to filter at all
- also, you can try to do it in one filter
src/components/TodoList/TodoList.tsx
Outdated
|
|
||
| <tbody> | ||
| {filteredTodos.map(({ id, completed, title, userId }) => ( | ||
| <tr key={id} data-cy="todo"> |
| const dispatch = useDispatch(); | ||
| const currentTodo = useAppSelector(state => state.currentTodo); | ||
| const [user, setUser] = useState<User>(); | ||
| const [loading, setLoading] = useState<boolean>(true); |
Comment on lines
20
to
21
| setLoading(true); | ||
| if (currentTodo) { |
There was a problem hiding this comment.
If there is no currentTodo user will see infinite loader
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DEMO LINK