Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Phone catalog #494

Open
wants to merge 14 commits into
base: master
Choose a base branch
from
Open

Phone catalog #494

wants to merge 14 commits into from

Conversation

NastyaSid
Copy link

@NastyaSid NastyaSid commented Sep 2, 2024 •
edited
Loading

@TarasHoliuk
Copy link

  1. The bug observed:
  • select 4 items/page
  • select 31 page
  • start search
  • observe result:
    image

It would be nice to set 1st page when the search input changes (or when the number of pages changes after input change)

  1. Remove the item from the cart when clicking this button again (now it adds duplicates to the cart):
    image

  2. These numbers should always be the same:
    image

TarasHoliuk
TarasHoliuk suggested changes Sep 2, 2024
View reviewed changes
Copy link

@TarasHoliuk TarasHoliuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It works and looks really great!

But a few improvements are required

anastasiiavorobiova
anastasiiavorobiova approved these changes Sep 3, 2024
View reviewed changes
Copy link

@anastasiiavorobiova anastasiiavorobiova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anastasiiavorobiova anastasiiavorobiova anastasiiavorobiova approved these changes

@TarasHoliuk TarasHoliuk Awaiting requested review from TarasHoliuk

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@NastyaSid @TarasHoliuk @anastasiiavorobiova