Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Develop #481

Open
wants to merge 35 commits into
base: master
Choose a base branch
from
Open

Develop #481

wants to merge 35 commits into from

Conversation

pakhomovalex
Copy link

@pakhomovalex pakhomovalex commented Aug 13, 2024 •
edited
Loading

etojeDenys
etojeDenys suggested changes Aug 13, 2024
View reviewed changes
Copy link

@etojeDenys etojeDenys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

your demo link leads to 404 page
image

feel free to ask for some help in the chat

@pakhomovalex
try to deploy
c233780
@pakhomovalex
try again to deploy
7bc5fc8
@pakhomovalex
add catalog
c2ed547
@pakhomovalex
add basic product details with change colors & images
6534235
@pakhomovalex
add capasity select and description for product
f3bc384
@pakhomovalex
add tablet version for product details & fix some routes, but problem…
713b826 
… with homepage product link
@pakhomovalex
fix image select
29133b4
@pakhomovalex
fix routes
232ef25
@pakhomovalex
add loader, add not found phones/table..., pass all tests
ace44f7
@pakhomovalex
fix not found page
b4f8960
@pakhomovalex
trying favorite page
4a92bbd
@pakhomovalex
trying favorite page 2
8e04f03
@pakhomovalex
trying favorite page 3
baf6048
@pakhomovalex
trying favorite page 4
be995d3
@pakhomovalex
add all pictures
f630ce0
@pakhomovalex
add working favorite page with too many re-renders
1d7deae
@pakhomovalex
fix add to card button
c31712c
@pakhomovalex
complete favorite page without errors, implement zustand libraly
9c43aaf
@pakhomovalex
add design to favorite page & implement favorite function to a Produc…
1e74101 
…t details page
@pakhomovalex
add add product to basket and edit there logic
c642c83
@pakhomovalex
fix few problems add final design
ab3a072
volodymyr-soltys97
volodymyr-soltys97 suggested changes Aug 31, 2024
View reviewed changes
Copy link

@volodymyr-soltys97 volodymyr-soltys97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, the demo link is empty now, you need to fix it
image

VitaliyBondarenko1982
VitaliyBondarenko1982 suggested changes Sep 1, 2024
View reviewed changes
Copy link

@VitaliyBondarenko1982 VitaliyBondarenko1982 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job.
Slider on mobile view looks not good.
Screenshot 2024-09-01 at 19 04 58

volodymyr-soltys97
volodymyr-soltys97 suggested changes Sep 2, 2024
View reviewed changes
Copy link

@volodymyr-soltys97 volodymyr-soltys97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job!
To improve:

  1. Add a favicon on the page
image
  1. Links should span the entire height of the header
image
  1. Add hover effects for all clickable elements
image
  1. Add cursor pointer for all clickable elements
image image
  1. The footer should be at the bottom of the page
image
  1. Add transition when this menu appears on the page
image

@TarasHoliuk
Copy link

  1. Nothing happens when I click Checkout button:
    image

Requirements:
image

  1. Add some space between price and price with a discount (same on product details page). Also (optionally), as for me it seems you should display cards on the left side (when you have > 4 you do it, but in one row it looks different):
    image

  2. Add a link to your GitHub account) Do not forget to open it in the new tab (it's an external link):
    image

TarasHoliuk
TarasHoliuk suggested changes Sep 2, 2024
View reviewed changes
Copy link

@TarasHoliuk TarasHoliuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GJ 👍
A few more fixes are required 🙂

anastasiiavorobiova
anastasiiavorobiova suggested changes Sep 3, 2024
View reviewed changes
Copy link

@anastasiiavorobiova anastasiiavorobiova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work!

Consider fixing console errors
Screenshot 2024-09-03 at 16 44 06

anastasiiavorobiova
anastasiiavorobiova approved these changes Sep 3, 2024
View reviewed changes
Copy link

@anastasiiavorobiova anastasiiavorobiova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anastasiiavorobiova anastasiiavorobiova anastasiiavorobiova approved these changes

@etojeDenys etojeDenys Awaiting requested review from etojeDenys

@VitaliyBondarenko1982 VitaliyBondarenko1982 Awaiting requested review from VitaliyBondarenko1982

@volodymyr-soltys97 volodymyr-soltys97 Awaiting requested review from volodymyr-soltys97

@TarasHoliuk TarasHoliuk Awaiting requested review from TarasHoliuk

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@pakhomovalex @TarasHoliuk @VitaliyBondarenko1982 @volodymyr-soltys97 @etojeDenys @anastasiiavorobiova