add task solution #1074
Open
add task solution #1074
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
volodymyr-soltys97
suggested changes
Oct 4, 2024
| return searchParams.getAll('centuries') || []; | ||
| }, [searchParams]); | ||
|
|
||
| function setSearchWith(paramsToUpdate: Params) { |
There was a problem hiding this comment.
It is important to stick to the same way of functions everywhere, fix it everywhere
Suggested change
| function setSearchWith(paramsToUpdate: Params) { | |
| const setSearchWith = (paramsToUpdate: Params) => { |
| return 'All'; | ||
| } | ||
|
|
||
| return sex === 'm' ? 'Male' : 'Female'; |
There was a problem hiding this comment.
Move gender values to enum and use it everywhere
Comment on lines
+69
to
+73
| case 'm': | ||
| return person.sex === 'm'; | ||
|
|
||
| case 'f': | ||
| return person.sex === 'f'; |
| <div className="panel-block"> | ||
| <div className="level is-flex-grow-1 is-mobile" data-cy="CenturyFilter"> | ||
| <div className="level-left"> | ||
| {['16', '17', '18', '19', '20'].map(item => ( |
There was a problem hiding this comment.
Move this array to the variable and use it here
| > | ||
| <thead> | ||
| <tr> | ||
| {['Name', 'Sex', 'Born', 'Died'].map(item => { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://oleksandr-vol.github.io/react_people-table-advanced/