Develop #1066
Open
Develop #1066
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jv-aquino
approved these changes
Sep 27, 2024
| function handleQueryChange(e: React.ChangeEvent<HTMLInputElement>) { | ||
| setSearchWith({ query: e.target.value || null }); | ||
| } | ||
|
|
||
| return ( | ||
| <nav className="panel"> | ||
| <p className="panel-heading">Filters</p> | ||
|
|
||
| <p className="panel-tabs" data-cy="SexFilter"> |
There was a problem hiding this comment.
the best use of BEM here would be panel__tabs (i think)
the exercise might be a little outdated
src/components/PeoplePage.tsx
Outdated
| }), | ||
| ) | ||
| .finally(() => dispatch({ type: 'isReady', payload: true })); | ||
| }, []); |
src/components/PeopleTable.tsx
Outdated
|
|
||
| useEffect(() => { | ||
| handleQueryFilterChange(); | ||
| }, [query]); |
There was a problem hiding this comment.
the handle function should also be in the dependencies
|
oh btw I forgot, there is a small UI mistake also, the headers are staying almost below the nav, try to fix that later plz |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://arthurfujii.github.io/react_people-table-advanced/