-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
my solution #1064
base: master
Are you sure you want to change the base?
my solution #1064
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Almost done!
src/components/PeopleFilters.tsx
Outdated
setSearchParams(params); | ||
} | ||
|
||
function handleQueryChange(event: React.ChangeEvent<HTMLInputElement>) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is important to follow the same way of creating functions, fix it everywhere
function handleQueryChange(event: React.ChangeEvent<HTMLInputElement>) { | |
const handleQueryChange = (event: React.ChangeEvent<HTMLInputElement>) => { |
src/components/PeoplePage.tsx
Outdated
|
||
<PeopleTable /> | ||
{!loading && !error && filteredPeople.length === 0 && ( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
{!loading && !error && filteredPeople.length === 0 && ( | |
{!loading && !error && !filteredPeople.length && ( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work! 🔥
DEMO LINK