Develop #1058
Open
Develop #1058
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
etojeDenys
suggested changes
Sep 13, 2024
src/PeopleTable/PeopleTable.tsx
Outdated
Comment on lines
82
to
95
| {person.motherName ? ( | ||
| motherSlug ? ( | ||
| <a | ||
| href={`#/people/${motherSlug}`} | ||
| className="has-text-danger" | ||
| > | ||
| {person.motherName} | ||
| </a> | ||
| ) : ( | ||
| <span>{person.motherName}</span> | ||
| ) | ||
| ) : ( | ||
| '-' | ||
| )} |
There was a problem hiding this comment.
Suggested change
| {person.motherName ? ( | |
| motherSlug ? ( | |
| <a | |
| href={`#/people/${motherSlug}`} | |
| className="has-text-danger" | |
| > | |
| {person.motherName} | |
| </a> | |
| ) : ( | |
| <span>{person.motherName}</span> | |
| ) | |
| ) : ( | |
| '-' | |
| )} | |
| {motherSlug ? ( | |
| <a | |
| href={`#/people/${motherSlug}`} | |
| className="has-text-danger" | |
| > | |
| {person.motherName} | |
| </a> | |
| ) : ( | |
| <span>{person.motherName || '-'}</span> | |
| )} |
src/PeopleTable/PeopleTable.tsx
Outdated
Comment on lines
23
to
25
| const foundPerson = persons.find(person => person.name === name); | ||
|
|
||
| return foundPerson ? foundPerson.slug : undefined; |
There was a problem hiding this comment.
Suggested change
| const foundPerson = persons.find(person => person.name === name); | |
| return foundPerson ? foundPerson.slug : undefined; | |
| return persons.find(person => person.name === name)?.slug; |
src/PeoplePage/PeoplePage.tsx
Outdated
Comment on lines
104
to
105
| {loading && <Loader />} | ||
| {!loading && ( |
There was a problem hiding this comment.
better to simplify it using the ternary operator
anastasiiavorobiova
suggested changes
Sep 16, 2024
volodymyr-soltys97
suggested changes
Sep 16, 2024
|
sorry i forget to deploy it |
TarasHoliuk
approved these changes
Sep 16, 2024
| > | ||
| <thead> | ||
| <tr> | ||
| <th onClick={() => onSort('name')}>Name {getSortIcon('name')}</th> |
There was a problem hiding this comment.
Suggested change
| <th onClick={() => onSort('name')}>Name {getSortIcon('name')}</th> | |
| <th onClick={() => onSort('name')}>Name{getSortIcon('name')}</th> |
That is the reason tests fail
| > | ||
| <td> | ||
| <a | ||
| className={person.sex === 'f' ? 'has-text-danger' : ''} |
There was a problem hiding this comment.
it's better to use classnames library for conditional classes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://ogchy.github.io/react_people-table-advanced/