Solution #1053
Open
Solution #1053
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TarasHoliuk
suggested changes
Sep 9, 2024
src/components/PeopleFilters.tsx
Outdated
| onCenturyFilterChange, | ||
| }) => { | ||
| const [selectedSex, setSelectedSex] = useState<string | null>(null); | ||
| const handleSexFilterChange = (sex: string | null) => { |
There was a problem hiding this comment.
it's redundant function wrapper. You can just use setSelectedSex everywhere instead of handleSexFilterChange
src/components/PeoplePage.tsx
Outdated
| return matchesQuery && matchesCentury && matchesSex; | ||
| }); | ||
|
|
||
| const sortedPeople = [...filteredPeople].sort((a, b) => { |
There was a problem hiding this comment.
You can wrap it into useMemo to avoid recalculating it every time an unrelated state or search parameter changes. Same for filteredPeople
src/components/personLink.tsx
Outdated
| return ( | ||
| <td> | ||
| <Link | ||
| to={`./${person.slug}`} |
There was a problem hiding this comment.
It resets all filters. That unexpected behavior - should be fixed
anastasiiavorobiova
suggested changes
Sep 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DEMO LINK