Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

solution #2584

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

solution #2584

wants to merge 2 commits into from

Conversation

Shevchuchka
Copy link

Copy link

@anastasiiavorobiova anastasiiavorobiova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work! Almost done!

src/App.tsx Outdated
const [showModal, setShowModal] = useState(false);

useEffect(() => {
const delayTimer = setTimeout(() => setLoading(true), 300);

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
const delayTimer = setTimeout(() => setLoading(true), 300);
setLoading(true);

src/App.tsx Outdated
Comment on lines 27 to 28
clearTimeout(delayTimer);
setTimeout(() => setLoading(false), 500);

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
clearTimeout(delayTimer);
setTimeout(() => setLoading(false), 500);
setLoading(false);

src/api.ts Outdated

export const getFilteredTodos = (value: string) => {
switch (value) {
case 'all':

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider creating an enum for status

// const normalizedQuery = query.toLowerCase();

const handleDelete = () => {
setSelectedValue('all');

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
setSelectedValue('all');

Copy link

@anastasiiavorobiova anastasiiavorobiova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants